Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RC 428 to Production #11453

Merged
merged 29 commits into from
Nov 5, 2024
Merged

Deploy RC 428 to Production #11453

merged 29 commits into from
Nov 5, 2024

Conversation

jmhooper
Copy link
Member

@jmhooper jmhooper commented Nov 5, 2024

User-Facing Improvements

  • Email Reports: Add Login.gov colors to resport tables (LG-14431) (#11410)
  • Facial Match: Configuration for releasing GA (#11418)
  • In-person proofing: Update mobile layout for how to verify (#11431)
  • Localization: Improve Spanish for reCAPTCHA disclosure and partner selected email (#11448)
  • Reports: Add Login.gov branding to automated email reports (#11444)

Bug Fixes

  • Doc Auth: Fix screenreader saying No File Chosen on inputs (#11422)

Internal

  • AAMVA: Update Montana's maintenance window (#11426)
  • Analytics: Track visits from "You verified your identity" email (#11413)
  • Analytics: Add logging property for unchanged password reset of verified account (#11423)
  • Analytics: Fix bug in protocols report (Internal, Analytics, Fix bug in protocols report #11447) (#11447)
  • Automated Testing: Use shared examples for mailer preview specs (#11446)
  • Dependencies: Update Login.gov Design System from v9.3.0 to v9.4.0 (#11435)
  • Dependencies: Integrate and remove dependency on Airbnb ESLint rules (#11445)
  • Doc Auth: Add feature flag to enable standard socure doc capture in lower environments (#11438)
  • Documentation: Clarify usage of kubernetes configurations and files (#11450)
  • Fraud review: Attribute fraud review analytics events to SPs. (#11390)
  • Maintenance: Update premailer and zxcvbn (#11437, #11442)
  • Reporting: Add new daily sensitive job (#11405)
  • Reporting: Naming improvements for table stats export (#11419)
  • Upcoming Features: Create A/B test to recommend platform authenticator to SMS users (#11402)

Upcoming Features

  • Doc Auth: Add an interstitial page for socure (#11429)
  • Partner Email Selection: Display flash message on successful update (#11432)

colter-nattrass and others added 29 commits October 30, 2024 11:07
* LG-14548 Improve directory naming for table summary exports

changelog: Internal, Reporting, naming improvements for table stats export
* LG-14830 | Adds MT DMV maintenance window

changelog: Internal, AAMVA, Update Montana's maintenance window
…#11413)

**Why?**

* We want to measure the frequency and distribution of user sign-ins
  from the "You've verified your identity" email notification

**How?**

* A new controller and route to capture the "visit" and redirect to the
  ServiceProvider's homepage URL

* Updated the AccountVerifiedPresenter to wrap the ServiceProvider's
  homepage URL with our new route

changelog: Internal, Analytics, Track visits from "You verified your identity" email
* Log password changed

* Document analytics property

* Add spec coverage for password_different

* changelog: Internal, Analytics, Add logging property for unchanged password reset of verified account

* Typo: Profile deactivated

* Invert password_different to password_matches_existing

Co-authored-by: Zach Margolis <[email protected]>

* Refactor form specs for updated expectations

* Add form test case for password_matches_existing

* A/B test subset of password resets for logging

* Remove inaccurate route verb

Co-authored-by: Zach Margolis <[email protected]>

---------

Co-authored-by: Zach Margolis <[email protected]>
…e input value to null (#11422)

* remove the useEffect that sets the file input value to null

changelog: Bug Fixes, Doc Auth, Fix screenreader saying No File Chosen on inputs

* remove aria-label from input in FileInput

* linty mclinterson

* fix ipp spec with aria-label for input now removed
changelog: Internal, Maintenance, Update premailer and zxcvbn
changelog: Upcoming Features, Partner Email Selection, Display flash message on successful update
changelog: Internal, Dependencies, Update Login.gov Design System from v9.3.0 to v9.4.0
* LG-14431 update email report table colors

* LG-14431 use only appropriate variables

* LG-14431 fix lint
changelog: User-Facing Improvements, Email Reports, Add Login.gov colors to resport tables (LG-14431)

* LG-14431 refactor for design system patterns

changelog: User-Facing Improvements, Email Reports, Add Login.gov colors to resport tables (LG-14431)

* LG-14431 remove row headers
* Update mobile view for how to verify

* changelog: User-Facing Improvements, In-person proofing, Update mobile layout for how to verify

* Remove conditional class

* Update classes for margins on How to Verify
changelog: Internal, Maintenance, Update premailer and zxcvbn
* Refactor ThreatMetrix out into a plugin

For now, just take the proof_with_threatmetrix_if_needed method + deps and move into a different file.

[skip changelog]

* Remove unused methods from spec

* Update app/services/proofing/resolution/plugins/threat_metrix_plugin.rb

Co-authored-by: Zach Margolis <[email protected]>

* Add sp_cost_count method to TMX plugin spec

Allows much cleaner (1-line) checking of whether the plugin modifies cost counts

* Remove stray allow in ProgressiveProofer spec

---------

Co-authored-by: Zach Margolis <[email protected]>
…r lower environments (#11438)

changelog: Internal, Doc Auth, add feature flag to enable standard socure doc capture in lower environments
* Add AamvaPlugin

Add a new resolution plugin for AAMVA and call it from the ProgressiveProofer.

[skip changelog]

* Make aamva_supports_state_id_jurisdiction? not a class method

And add a spec for it

* Track that costs are logged with a transaction ID
changelog: Internal, Dependencies, Integrate and remove dependency on Airbnb ESLint rules
* Use shared examples for mailer preview specs

changelog: Internal, Automated Testing, Use shared examples for mailer preview specs

* Update deleted user accounts report test data

Co-authored-by: Zach Margolis <[email protected]>

* Extract heredoc variable

Avoids comma lint issue where comma required after parameter, but incompatible with heredoc syntax

* Add demo name for deleted_user_accounts_report

---------

Co-authored-by: Zach Margolis <[email protected]>
* add doc capture interstital page

* move interstitial to shared file

* do not show sp if there is no sp

* normalize yml

* redirect to idv_unavailable if url is nil

* add changelog

changelog: Upcoming Features, Doc Auth, add an interstitial page for socure

* add a return infront of the redirect_to to terminate the request

* add missing period to text
* changelog: User-Facing Improvements, Facial Match, Configuration for releasing GA
* lg-14425 new sensitive job

changelog: Internal, Reporting,add new daily sensitive job

* Refactor job

* update bucket config

* schema

* update bucket - spec - and comments

* cron schedule edit

---------

Co-authored-by: Aaron Nagucki <[email protected]>
* Add the login.gov logo and the separator bars

changelog: User-Facing Improvements, Reports, Add Login.gov branding to automated email reports

* Don’t @forward utilities, include as needed

* Include border-color as well

* Lint fix

* Lint: Take 2

* Use the png logo

* Update app/views/report_mailer/tables_report.html.erb

Co-authored-by: Andrew Duthie <[email protected]>

* Update app/assets/stylesheets/tables-report.css.scss

Co-authored-by: Andrew Duthie <[email protected]>

* Update app/assets/stylesheets/tables-report.css.scss

Co-authored-by: Andrew Duthie <[email protected]>

---------

Co-authored-by: Andrew Duthie <[email protected]>
…11402)

* LG-14655: A/B test to recommend platform authenticator to SMS users

changelog: Internal, Upcoming Features, Create A/B test to recommend platform authenticator to SMS users

* Restore test case

Mistakenly removed in rebase

* Convert "should" to "expect" syntax

* Update experiment name

Standardize on "recommend" terminology, also broaden to cover account creation flow

* Sort analytics methods

* Check in multi-MFA setup flow for suggesting second MFA

* Remove redundant, inaccurate test case

* Add specs for RECOMMEND_WEBAUTHN_PLATFORM_FOR_SMS_USER AbTest

* Split configuration for authentication vs. account creation
* Update review-reject to attribute events to SP

changelog: Internal, Fraud review, Attribute fraud review analytics events to SPs.

* Update review-pass to attribute events to SP

* Allow logging SP without a request

Update Analytics to always attempt to log SP, even when there is no associated request.

* Don't log extraneous event

If include_missing is specified and there are no missing users, don't log an event for them

* Add test for logging SP without request

* Add parameter documentation for Analytics initializer

* Update analytics spec

Include service_provider in analytics_attributes now that it does not depend on request being non-nil.
* Log Socure reason code descriptions

Save us a step when analyzing data and include descriptions for known reason codes when logging.

[skip changelog]

* Fix error message in mock resolution proofer

I was wondering why I was getting an address timeout during resoltuion

* Update specs for resolution mock client

* Update reason code logging spec

* Use '[unknown]' rather than '' for unknown reason codes

* Fix a spec I missed
changelog: User-Facing Improvements, Localization, Improve Spanish for reCAPTCHA disclosure and partner selected email
…11433)

* Extract residential address InstantVerify plugin

Add separate spec for the residential address verification only.

[skip changelog]

* Remove duplicative test from ResolutionProofingJob spec

This test is essentially doing what the ProgressiveProofer spec is doing.
…les (#11450)

changelog: Internal, Documentation, Clarify usage of kubernetes configurations and files
* Extract InstantVerifyStateIdAddressPlugin

Add plugin to do IV calls for state ID addresses, along with a spec covering its usage

[skip changelog]

* Fix spec
@jmhooper jmhooper merged commit 7fc5046 into stages/prod Nov 5, 2024
1 check passed
@jmhooper jmhooper deleted the stages/rc-2024-11-05 branch November 5, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.