-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the login.gov logo and the separator bars #11444
Add the login.gov logo and the separator bars #11444
Conversation
changelog: User-Facing Improvements, Reports, Add Login.gov branding to automated email reports
e5a8ff0
to
9f5a692
Compare
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise looks good, but I'd defer to your team whether this fulfills the requirements of the ticket.
Co-authored-by: Andrew Duthie <[email protected]>
height: 21, | ||
) %> | ||
</header> | ||
<hr class="height-05 margin-bottom-4 border-transparent"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the changes proposed in my previous comment, it required corresponding changes to apply the background color class here. I'm guessing there's no color in your merged code.
🎫 Ticket
Link to the relevant ticket:
LG-14793
🛠 Summary of changes
Adds Login.gov logo before the report and separators around the data to better brand the emails to Login.gov.
👀 Screenshots
Before
After