Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the login.gov logo and the separator bars #11444

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Add the login.gov logo and the separator bars #11444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9f5a692
Add the login.gov logo and the separator bars
Jeremy1026 Nov 1, 2024
a6c23c8
Don’t @forward utilities, include as needed
Jeremy1026 Nov 1, 2024
27237bb
Include border-color as well
Jeremy1026 Nov 1, 2024
9197b5d
Lint fix
Jeremy1026 Nov 1, 2024
f105d60
Lint: Take 2
Jeremy1026 Nov 1, 2024
7783c7e
Use the png logo
Jeremy1026 Nov 1, 2024
d0496cc
Update app/views/report_mailer/tables_report.html.erb
Jeremy1026 Nov 4, 2024
65ca085
Update app/assets/stylesheets/tables-report.css.scss
Jeremy1026 Nov 4, 2024
2aabf88
Update app/assets/stylesheets/tables-report.css.scss
Jeremy1026 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/assets/stylesheets/tables-report.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,26 @@
@forward 'usa-table';
@forward 'usa-alert';

.bg-secondary {
@include u-bg('secondary');
}

.margin-bottom-4 {
@include u-margin-bottom(4);
}

.margin-top-4 {
@include u-margin-top(4);
}

.height-05 {
@include u-height(0.5);
}

.border-transparent {
@include u-border-color('transparent');
}

.report-title,
.report-subtitle {
color: color('primary-darker');
Expand Down
10 changes: 10 additions & 0 deletions app/views/report_mailer/tables_report.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
- @message: text to put in the beginning of the email
- @reports: an array of EmailableReport
%>
<header class="usa-header">
<%= image_tag(
asset_url('email/logo.png'),
alt: APP_NAME,
width: 155,
height: 21,
) %>
</header>
<hr class="height-05 margin-bottom-4 border-transparent">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changes proposed in my previous comment, it required corresponding changes to apply the background color class here. I'm guessing there's no color in your merged code.

<%= @message %><br>
<% @reports.each do |report| %>
<% header, *rows = report.table %>
Expand Down Expand Up @@ -38,3 +47,4 @@
</tbody>
</table>
<% end %>
<hr class="height-05 margin-top-4 border-transparent">