Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing bg-secondary class to make HR be red #11465

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Jeremy1026
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14793

🛠 Summary of changes

In the edits to my previous PR for report branding the color for the HR was lost because the new CSS class wasn't applied to the <hr> in the template. This adds the class to make the horizontal rule be red.

👀 Screenshots

image

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to approve, I'm suspecting additional changes are needed per my review comment.

changelog: User-Facing Improvements, Automated Reports, Add color class to the recently added HRs
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeremy1026 Jeremy1026 merged commit cc00194 into main Nov 7, 2024
2 checks passed
@Jeremy1026 Jeremy1026 deleted the jcurcio/LG-14793/include-bg-color-class branch November 7, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants