-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressiveProofer refactor 2/N: AAMVA #11427
Conversation
def call( | ||
applicant_pii:, | ||
current_sp:, | ||
instant_verify_result:, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the IPP + different addresses case, if the residential address failed verification, then instant_verify_result will have success: false
and vendor_name: ResolutionCannotPass
, so no AAMVA call will be made.
856bb84
to
9e310dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not run through the checklist you provided, and someone should before merging. But I spent a while working through the code and it looks solid.
) | ||
end | ||
|
||
it 'does not make an AAMVA call because get to yes is not supported' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ for this descriptive name -- it makes perfectly clear why we go from "but the failure can possibly be covered by AAMVA" to "does not make an AAMVA call"
Add a new resolution plugin for AAMVA and call it from the ProgressiveProofer. [skip changelog]
And add a spec for it
9e310dc
to
2507939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic for existing code and new plugin remains the same. I manually tested IPP with AAMVA approved jurisdictions (CO) and not approved (CA) and get the outcome I'd expect. (For both cases; same address as ID, diff address as ID.)
🛠 Summary of changes
Continuing the work in #11420, this PR extracts
proof_id_with_aamva_if_needed
intoAamvaPlugin
. It then adds a spec for the plugin covering the following use cases:📜 Testing Plan
Provide a checklist of steps to confirm the changes.