Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressiveProofer refactor 2/N: AAMVA #11427

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

matthinz
Copy link
Member

🛠 Summary of changes

Continuing the work in #11420, this PR extracts proof_id_with_aamva_if_needed into AamvaPlugin. It then adds a spec for the plugin covering the following use cases:

  • Remote unsupervised proofing
  • In-person proofing (residential address == id address)
  • In-person proofing (residential address != id address)

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Run through remote unsupervised IdV using an ID from an AAMVA state
  • Run through remote unsupervised IdV using an ID from a non-AAMVA state
  • Run through in-person proofing using an ID from an AAMVA state (same address as id)
  • Run through in-person proofing using an ID from a non-AAMVA state (same address as id)
  • Run through in-person proofing using an ID from an AAMVA state (different address than id)
  • Run through in-person proofing using an ID from a non-AAMVA state (different address than id)

@matthinz matthinz requested a review from a team October 30, 2024 19:38
def call(
applicant_pii:,
current_sp:,
instant_verify_result:,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in the IPP + different addresses case, if the residential address failed verification, then instant_verify_result will have success: false and vendor_name: ResolutionCannotPass, so no AAMVA call will be made.

Copy link
Member

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not run through the checklist you provided, and someone should before merging. But I spent a while working through the code and it looks solid.

)
end

it 'does not make an AAMVA call because get to yes is not supported' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ for this descriptive name -- it makes perfectly clear why we go from "but the failure can possibly be covered by AAMVA" to "does not make an AAMVA call"

Base automatically changed from matthinz/prog-proofer-refactor-01-threatmetrix to main November 1, 2024 15:59
Add a new resolution plugin for AAMVA and call it from the ProgressiveProofer.

[skip changelog]
@matthinz matthinz force-pushed the matthinz/prog-proofer-refactor-02-aamva branch from 9e310dc to 2507939 Compare November 1, 2024 16:12
@gina-yamada gina-yamada self-requested a review November 1, 2024 16:38
Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic for existing code and new plugin remains the same. I manually tested IPP with AAMVA approved jurisdictions (CO) and not approved (CA) and get the outcome I'd expect. (For both cases; same address as ID, diff address as ID.)

@matthinz matthinz merged commit e797044 into main Nov 1, 2024
2 checks passed
@matthinz matthinz deleted the matthinz/prog-proofer-refactor-02-aamva branch November 1, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants