Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update premailer and zxcvbn dependencies #11437

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mitchellhenke
Copy link
Contributor

🛠 Summary of changes

This makes an update to a couple of dependencies (and their dependencies) to include some performance updates in the new versions.

changelog: Internal, Maintenance, Update premailer and zxcvbn
@mitchellhenke mitchellhenke requested a review from a team October 31, 2024 17:22
@mitchellhenke mitchellhenke merged commit 29c3a3b into main Oct 31, 2024
2 checks passed
@mitchellhenke mitchellhenke deleted the mitchellhenke/update-deps-3 branch October 31, 2024 17:57
@@ -91,7 +91,7 @@ gem 'zlib', require: false

# This version of the zxcvbn gem matches the data and behavior of the zxcvbn NPM package.
# It should not be updated without verifying that the behavior still matches JS version 4.4.2.
gem 'zxcvbn', '0.1.9'
gem 'zxcvbn', '0.1.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been bumped to 0.1.12, the latest version (including your contribution 😄 )?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yes, typo on my part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up: #11442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants