Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray Icon disappears on Screen Lock & Unlock #910

Closed
1 of 3 tasks
punchagan opened this issue Mar 31, 2020 · 19 comments
Closed
1 of 3 tasks

Tray Icon disappears on Screen Lock & Unlock #910

punchagan opened this issue Mar 31, 2020 · 19 comments

Comments

@punchagan
Copy link
Member

punchagan commented Mar 31, 2020

  • Operating System:
    • Windows
    • Linux/Ubuntu
    • macOS

I'm on Ubuntu Focal (GNOME Shell 3.36.0).

When running the desktop app on the latest master, the tray icon seems to disappear when I lock my screen and unlock it. Hard reloading the app seems to restore it. CZO discussion here.

@andersk
Copy link
Member

andersk commented Mar 31, 2020

This seems to be an upstream problem that affects all applications, so there probably isn’t anything we can do. See ubuntu/gnome-shell-extension-appindicator#75.

@fauust
Copy link

fauust commented Apr 1, 2020

Same here, tray icon has just gone

OS: Debian Buster
Window manager: i3wm + polybar

@fauust
Copy link

fauust commented Apr 2, 2020

Any chance that this could be related to electron/electron#21445?
See also keybase/client#23347.

@imolein
Copy link

imolein commented Apr 2, 2020

Same here, tray icon is gone since I updated the desktop app to version 5.0.0.

OS: Xubuntu 18.04.3
WM: XFCE

@dotenorio
Copy link

I solved this with this code:

  if (os.platform() !== 'linux') return

  const monit = exec(`
    dbus-monitor --session "type='signal',interface='org.gnome.ScreenSaver'" |
    while read x; do
      case "$x" in 
        *"boolean true"*) echo SCREEN_LOCKED;;
        *"boolean false"*) echo SCREEN_UNLOCKED;;  
      esac
    done
  `)

  monit.stdout.on('data', (data) => {
    const out = data.toString().trim()
    if (out === 'SCREEN_UNLOCKED') {
      tray.destroy()
      createTray()
    }
  })

You can see more about this in my repo https://github.com/dotenorio/clipboard-manager-electron/ on lib/create_window.js line 350

@imolein
Copy link

imolein commented Apr 3, 2020

As described in comment electron/electron#21445 (comment) I can confirm it is working with xfce4-statusnotifier-plugin in Xubuntu 18.04

@devurandom
Copy link

devurandom commented Apr 6, 2020

On KDE Plasma, using the Flatpak, I never see any tray icon at all on these two systems (i.e. not even right after start of the application, which is a problem if startMinimized=true in ~/.config/Zulip/config/settings.json):

Operating System: Gentoo Linux 
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Kernel Version: 5.5.14
OS Type: 64-bit
Operating System: Fedora 31
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.67.0
Qt Version: 5.13.2
Kernel Version: 5.5.13-200.fc31.x86_64
OS Type: 64-bit

See-Also: flathub/org.zulip.Zulip#18

@fauust
Copy link

fauust commented Apr 20, 2020

Hi!
Since 5.0.0 was released (19 days ago) the tray icon is completely missing. If my understanding is correct this is not directly related to zulip but to electron electron/electron#21445.

I have tried to revert to 4.0.3 version but this seems to be impossible, I have also looked for beta releases following https://zulipchat.com/help/desktop-app-install-guide#install-a-beta-release.

So my only solution for now is to use the browser version or to live without tray icon and the notification counter...

Does anybody has a workaround to share with me? Building a version from source is an option I could consider of course!

Regards,
Faustin

@fauust
Copy link

fauust commented Apr 20, 2020

Side note: my issue is not exactly this one (tray icon is totally missing), should I open a new issue?

@akashnimare
Copy link
Member

@fauust please file a new bug with detailed info (Linux distro, app installer type etc).

@devurandom
Copy link

Side note: my issue is not exactly this one (tray icon is totally missing), should I open a new issue?

@fauust please file a new bug with detailed info (Linux distro, app installer type etc).

@fauust Please link it here afterwards, since I am having the exact same issue.

See-Also: #910 (comment)
See-Also: flathub/org.zulip.Zulip#18

@fauust
Copy link

fauust commented Apr 21, 2020

@akashnimare done #936

@abhigyank
Copy link
Collaborator

@punchagan A chromium bug was created for this
https://bugs.chromium.org/p/chromium/issues/detail?id=1042098 .
There is also a Gnome level issue at ubuntu/gnome-shell-extension-appindicator#220

I guess we have to wait for this to be fixed upstream. Till then one may build out of the hack of #922 if necessary.

@punchagan
Copy link
Member Author

Till then one may build out of the hack of #922 if necessary.

I think it is worth doing the hackish fix.

@abhigyank
Copy link
Collaborator

Electron is restoring to the original way of implementation for tray icon, so that should fix this issue for us. electron/electron#23674

@abhigyank
Copy link
Collaborator

@punchagan Can you test on the latest release? Electron has restored to the original way of implementation so this should be fixed in the older release.

@fauust
Copy link

fauust commented Jun 25, 2020

Latest version working again, see #936 (comment)

My setup:

  • debian 10
  • i3wm
  • polybar

@punchagan
Copy link
Member Author

@punchagan Can you test on the latest release?

I see the icon now, but I don't see the correct icon. I see ellipsis being shown instead of the Zulip logo. 🙈

image

@punchagan
Copy link
Member Author

I see the icon now, but I don't see the correct icon. I see ellipsis being shown instead of the Zulip logo. see_no_evil

This was when I was running from source. The snap shows the icon correctly. Just adding a note for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants