Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon goes away after locking/unlocking the screen #4082

Open
1 task done
fabiomargarido opened this issue Mar 25, 2020 · 18 comments
Open
1 task done

Tray icon goes away after locking/unlocking the screen #4082

fabiomargarido opened this issue Mar 25, 2020 · 18 comments

Comments

@fabiomargarido
Copy link

  • I have searched open and closed issues for duplicates

Bug Description

When using the `--start-in-tray' option, everything works as expected but the systray icon disappears after locking the screen and unlocking again.

Steps to Reproduce

  1. Start signal-desktop with the --start-in-tray option;
  2. Wait for the app to start and verify that the systray icon works as expected;
  3. Lock the screen (Super+L on Ubuntu);
  4. Unlock the screen.

Actual Result:

The systray icon is gone but it is possible to see that the signal-desktop process is still running in the background.

Expected Result:

The systray icon is still shown and continues to work as expected.

Platform Info

Signal Version:

1.32.1

Operating System:

Ubuntu 18.04.0 LTS

Linked Device Version:

4.57.2

@majkeldzordan
Copy link

90669283_207872037226389_1248556313026232320_n

@N0GX
Copy link

N0GX commented Mar 26, 2020

I am seeing this as well after updating to v1.32.2 this morning.

@scottnonnenberg-signal
Copy link
Contributor

@majkeldzordan @N0GX This is the bug tracking that issue: #4085

@mandree
Copy link
Contributor

mandree commented Mar 26, 2020

On Fedora 31 Linux with GNOME 3 (3.34) desktop and TopIcons Plus as packaged by Fedora, I do not currently get the tray icon (neither in the panel nor in the dock), but I do get it with the Plasma (KDE) desktop. Some other icons (keepassxc) are also going missing on GNOME, so it may be an issue of GNOME... GNOME is notorious for breaking extensions and application icons every half year with each and every new release.

@fabiomargarido what desktop are you running on your Ubuntu?

@fabiomargarido
Copy link
Author

@mandree I'm running Gnome 3.28.4, the default for Ubuntu 18.04.

@mandree
Copy link
Contributor

mandree commented Mar 26, 2020

See #3974 for more details, and for GNOME, specifically this comment: #3974 (comment)

@bungabunga
Copy link

bungabunga commented Apr 2, 2020

@scottnonnenberg-signal there seems to be a solution for this: zulip/zulip-desktop#910

@mandree
Copy link
Contributor

mandree commented Apr 3, 2020

@bungabunga that seems to be more a workaround than a real solution, but it's not clear if GNOME or chromium/electron need to fix this. Electron are pointing fingers at GNOME and Chromium, see ubuntu/gnome-shell-extension-appindicator#220

@bungabunga
Copy link

@mandree can this workaround be implemented Signal-desktop-wise so that we don't have to wait for Electron, Gnome and Chromium to make up their minds?

@mandree
Copy link
Contributor

mandree commented Apr 4, 2020

It makes more sense to put massive pressure on GNOME for constantly breaking things and ask Chromium if they can help adjusting to the ever-changing GNOME environment, than fix hundreds of downstream users.

@tribut
Copy link

tribut commented Apr 4, 2020

But this is a regression in Electron/Chromium, no? This worked on the same version of GNOME before the update of Electron? How is it GNOMEs fault? Haven't they been disabling extensions when the screen is locked since forever?

@scottnonnenberg-signal
Copy link
Contributor

Seems to be a chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1042098

@mandree
Copy link
Contributor

mandree commented Apr 7, 2020

To me that's not so clear... https://bugs.chromium.org/p/chromium/issues/detail?id=1042098#c11 and GNOME 3 is the desktop that has been reinventing everything every other year.

@loxK
Copy link

loxK commented Apr 27, 2020

Please implement the workaround in the meantime it is fixed upstream.

@bungabunga
Copy link

it seems there's gonna be a fix in electron.

@mandree
Copy link
Contributor

mandree commented Jun 7, 2020

it seems there's gonna be a fix in electron.

https://github.com/electron/electron/releases/tag/v9.0.3 was released with the fix, but as of today, this release has not yet hit the servers in a manner that yarn would accept it.

@mandree
Copy link
Contributor

mandree commented Jun 11, 2020

I've rebuilt Signal with Electron 9.0.3, which resolves this issue.
@scottnonnenberg-signal - please rebase Signal onto Electron 9.0.3 or newer.

@loxK
Copy link

loxK commented Jul 16, 2020

It is solved with the new version release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants