twister: Add means for requiring sysbuild from platform level #73790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
gchwier,
golowanow,
gopiotr,
hakehuang,
jaz1-nordic,
KamilxPaszkiet,
kl-cruz,
LukaszMrugala,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
miha-nordic
approved these changes
Jun 5, 2024
|
Please add it to nRF54L15 targets as well. |
PerMac
force-pushed
the
sysbuild_plat_yaml
branch
2 times, most recently
from
8721ea2 to
4266eb5
Compare
|
aligned pytest unit tests and rebased to fix unrelated twister failure |
PerMac
added a commit
to PerMac/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
More complex platforms require sysbuild to use always, even for such "simple" samples like hello_world. Such platforms can have `sysbuild: true` entry in their board_name.yaml used by twister. Using such entry will tell twister, that sysbuild must always be used on a given platform. Twister is aligned to have information about need of sysbuild at instance (platform + suite) level (was only at suite level before). Instance.sysbuild is true whenever a test suite or a platform requires sysbuild. Twister pytest unit tests are aligned with changes. Signed-off-by: Maciej Perkowski <[email protected]> Upstream PR: zephyrproject-rtos/zephyr#73790
PerMac
added a commit
to PerMac/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
…build in twister Nrf54h's and nrf54l's targets are the first targets complex enough that a sysbuild must be used on every build for them. This information is reflected in their yamls. These entries tell twister to always use sysbuild for those targets. Signed-off-by: Maciej Perkowski <[email protected]> Upstream PR: zephyrproject-rtos/zephyr#73790
nordic-segl
approved these changes
Jun 6, 2024
anangl
previously approved these changes
Jun 6, 2024
golowanow
previously approved these changes
Jun 6, 2024
PerMac
force-pushed
the
sysbuild_plat_yaml
branch
from
4266eb5 to
e745fad
Compare
PerMac
requested review from
gchwier,
nordic-segl,
nashif,
anangl,
masz-nordic and
golowanow
and removed request for
nordic-segl
nashif
approved these changes
Jun 7, 2024
nordic-segl
approved these changes
Jun 7, 2024
golowanow
approved these changes
Jun 7, 2024
masz-nordic
approved these changes
Jun 7, 2024
jaz1-nordic
approved these changes
Jun 7, 2024
|
@PerMac what is going on here? will you please fix the issues? |
|
buildsystem issue will be fixed with #74152 |
this one is now merged , please rebase. |
More complex platforms require sysbuild to use always, even for such "simple" samples like hello_world. Such platforms can have `sysbuild: true` entry in their board_name.yaml used by twister. Using such entry will tell twister, that sysbuild must always be used on a given platform. Twister is aligned to have information about need of sysbuild at instance (platform + suite) level (was only at suite level before). Instance.sysbuild is true whenever a test suite or a platform requires sysbuild. Twister pytest unit tests are aligned with changes. Signed-off-by: Maciej Perkowski <[email protected]>
Nrf54h's and nrf54l's targets are the first targets complex enough that a sysbuild must be used on every build for them. This information is reflected in their yamls. These entries tell twister to always use sysbuild for those targets. Signed-off-by: Maciej Perkowski <[email protected]>
PerMac
force-pushed
the
sysbuild_plat_yaml
branch
from
e745fad to
80ad595
Compare
|
@nashif rebased and green |
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
More complex platforms require sysbuild to use always, even for such "simple" samples like hello_world. Such platforms can have `sysbuild: true` entry in their board_name.yaml used by twister. Using such entry will tell twister, that sysbuild must always be used on a given platform. Twister is aligned to have information about need of sysbuild at instance (platform + suite) level (was only at suite level before). Instance.sysbuild is true whenever a test suite or a platform requires sysbuild. Twister pytest unit tests are aligned with changes. Signed-off-by: Maciej Perkowski <[email protected]> Upstream PR: zephyrproject-rtos/zephyr#73790 (cherry picked from commit f7bfc64)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
…build in twister Nrf54h's and nrf54l's targets are the first targets complex enough that a sysbuild must be used on every build for them. This information is reflected in their yamls. These entries tell twister to always use sysbuild for those targets. Signed-off-by: Maciej Perkowski <[email protected]> Upstream PR: zephyrproject-rtos/zephyr#73790 (cherry picked from commit b98ee62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some complex platforms (e.g. nrf54h20) requires sysbuild for all builds. Even simplest hello_world. This PR add option to configure such requirement (sysbuild: true) in platform_name.yaml which is used by twister. It tells twister to use sysbuild always for such target.
The PR also adds "sysbuild: true" to nrf54h20 targets yamls