-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: twister: add option to force using sysbuild for every testsuite #72942
scripts: twister: add option to force using sysbuild for every testsuite #72942
Conversation
CLI option which force to use sysbuild. Signed-off-by: Piotr Kosycarz <[email protected]>
FYI @masz-nordic |
This is supplement for #71348 |
@nashif @golowanow @hakehuang this is a rather trivial extension, similar to other we already use (e.g. --fixture, --extra-args, etc.) to pass an argument from the top twister call (CLI level) down to all builds |
Enable sysbuild for nrf54 nrfconnect/sdk-zephyr#1728 zephyrproject-rtos/zephyr#73076 zephyrproject-rtos/zephyr#72942 Signed-off-by: Sebastian Głąb <[email protected]>
I am not convinced this is trivial, maybe in the way it is implemented, however, it is very specific to a single usecase and needs additional command line options which makes it more custom and not generic, something like this need to be implemented at the test level and not be done using twister command line. Did you consider other options? |
…or every testsuite CLI option which force to use sysbuild. Upstream PR: zephyrproject-rtos/zephyr#72942 Signed-off-by: Piotr Kosycarz <[email protected]>
Enable sysbuild for nrf54 nrfconnect/sdk-zephyr#1728 zephyrproject-rtos/zephyr#73076 zephyrproject-rtos/zephyr#72942 Signed-off-by: Sebastian Głąb <[email protected]>
@nashif I get your point. I also prefer that if this is a platform config level info, it is added there, and not through twister call. This is an alternative solution #73790 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use #73790 instead
CLI option which force to use sysbuild.
The usecase:
Enable testing with twister for 'companion' cores, which needs luncher to start.
E.g. Luncher is executed at Application core and FLPR core executes test/sample.
Usage with west:
west build -b nrf54l15pdk/nrf54l15/cpuflpr . --sysbuild -- -DSB_CONFIG_VPR_LAUNCHER=y
Usage with twister:
python ./zephyr/scripts/twister --ninja --jobs 1 -T zephyr/samples/basic --platform nrf54l15pdk/nrf54l15/cpuflpr --device-testing --device-serial /dev/ttyACM0 --extra-args SB_CONFIG_VPR_LAUNCHER=y --west-flash --force-sysbuild