soc: nordic: add vpr_launcher in sysbuild #71348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
57300,
anangl,
jeremybettis,
nashif,
nordicjm and
tejlmand
|
First commit can be dropped and PR rebased |
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
385d27c to
9818b7f
Compare
|
Rebased |
nordicjm
reviewed
Apr 11, 2024
tejlmand
requested changes
Apr 11, 2024
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
9818b7f to
a8b93d1
Compare
|
Changed the mechanism that chooses snippet to base on board variant instead of Kconfig. |
nordicjm
previously approved these changes
Apr 15, 2024
tejlmand
previously approved these changes
Apr 17, 2024
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
a8b93d1 to
29632b4
Compare
|
Since #70892 has been merged, I've rebased and added a commit that enables nRF54L15 FLPR support. |
tejlmand
approved these changes
Apr 19, 2024
tejlmand
requested changes
Apr 19, 2024
57300
reviewed
Apr 24, 2024
tejlmand
requested changes
May 13, 2024
There was a problem hiding this comment.
let's remove the detailed board variant knowledge at SoC level code.
A generic handling of qualifiers can be accepted as that is not tied directly to board knowledge, and as additional bonus it will allow for additional / oot launcher snippets without changing the code.
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
29632b4 to
ce69b16
Compare
zephyrbot
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic and
nika-nordic
57300
previously approved these changes
May 13, 2024
tejlmand
previously approved these changes
May 14, 2024
jaz1-nordic
previously approved these changes
May 14, 2024
henrikbrixandersen
requested changes
May 14, 2024
masz-nordic
dismissed stale reviews from jaz1-nordic, tejlmand, and 57300
via
ae50e60
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
ce69b16 to
ae50e60
Compare
|
@henrikbrixandersen done |
henrikbrixandersen
approved these changes
May 14, 2024
tejlmand
approved these changes
May 14, 2024
`SB_CONFIG_VPR_LAUNCHER` can now be used in building a VPR target, to enable automatic building of image that will launch the VPR. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
vpr_soc_launcher
branch
from
ae50e60 to
680babc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #71320