samples: modules: canopennode: set bootloader in sample.yaml #74101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the bootloader choice for the sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used. Signed-off-by: Gerard Marull-Paretas <[email protected]>
zephyrbot
requested review from
alexanderwachter,
kartben,
martinjaeger,
nashif and
str4t0m
henrikbrixandersen
approved these changes
Jun 11, 2024
kartben
approved these changes
Jun 11, 2024
gmarull
added a commit
to gmarull/sdk-zephyr
that referenced
this pull request
Jun 11, 2024
…e.yaml Set the bootloader choice for the sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used. Upstream PR: zephyrproject-rtos/zephyr#74101 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 4ca5c66b34e973a83f909d06ffde857e90f57aa6)
This was referenced Jun 11, 2024
Merged
henrikbrixandersen
added
the
Hotfix
carlescufi
approved these changes
Jun 11, 2024
str4t0m
approved these changes
Jun 11, 2024
nordic-segl
approved these changes
Jun 12, 2024
nordicjm
approved these changes
Jun 12, 2024
nordic-piks
approved these changes
Jun 12, 2024
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 12, 2024
…e.yaml Set the bootloader choice for the sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used. Upstream PR: zephyrproject-rtos/zephyr#74101 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 4ca5c66b34e973a83f909d06ffde857e90f57aa6)
ahasztag
pushed a commit
to ahasztag/sdk-zephyr
that referenced
this pull request
Jun 18, 2024
…e.yaml Set the bootloader choice for the sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used. Upstream PR: zephyrproject-rtos/zephyr#74101 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 4ca5c66b34e973a83f909d06ffde857e90f57aa6)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
…e.yaml Set the bootloader choice for the sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used. Upstream PR: zephyrproject-rtos/zephyr#74101 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 4ca5c66b34e973a83f909d06ffde857e90f57aa6) (cherry picked from commit f9bfe53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the bootloader choice for the
sample.modules.canopennode.program_download test case in the sample.yaml file instead of sysbuild.conf. The reason for this change is to avoid building MCUboot by default when using the --sysbuild option, as it may not be compatible with all platforms. This is currently causing issues on platforms like nRF54H20 where sysbuild is always used.