Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply assorted ruff/flake8-simplify rules (SIM) #2259

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Apply assorted ruff/flake8-simplify rules (SIM) #2259

merged 2 commits into from
Sep 26, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 26, 2024 •
edited
Loading

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos
Apply ruff/flake8-simplify rule SIM103
dd2f5ce 
SIM103 Return the condition directly
@DimitriPapadopoulos
Apply ruff/flake8-simplify rule SIM118
6b04cb0 
SIM118 Use `key in dict` instead of `key in dict.keys()`
@jhamman
Copy link
Member

jhamman commented Sep 26, 2024

are we missing the change to pyproject.toml?

@DimitriPapadopoulos
Copy link
Contributor Author

Again, I'm not sure about enforcing SIM rules:

  • You could try ruff check --select SIM. Are you really interested in these rules?
  • I didn't like the idea of enforcing only SIM103 and SIM118. Would you like to enforce them?

@jhamman jhamman merged commit 3365928 into zarr-developers:v3 Sep 26, 2024
26 checks passed
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 27, 2024
@dcherian
Merge branch 'v3' into generalize-stateful-store
ae3bca5 
* v3: (21 commits)
  Default zarr.open to open_group if shape is not provided (zarr-developers#2158)
  feat: metadata-only support for storage transformers metadata (zarr-developers#2180)
  fix(async): set default concurrency to 10 tasks (zarr-developers#2256)
  chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217)
  feature(store): add LoggingStore wrapper (zarr-developers#2231)
  Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259)
  Add array storage helpers (zarr-developers#2065)
  Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258)
  No need to run DeepSource any more - we use ruff (zarr-developers#2261)
  Remove unnecessary lambda expression (zarr-developers#2260)
  Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239)
  Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229)
  Replace Gitter with Zulip (zarr-developers#2254)
  Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236)
  Fix multiple identical imports (zarr-developers#2241)
  Enforce ruff/flake8-return rules (RET) (zarr-developers#2237)
  Enforce ruff/flynt rules (FLY) (zarr-developers#2240)
  Fix fill_value handling for complex dtypes (zarr-developers#2200)
  Update V2 codec pipeline to use concrete classes (zarr-developers#2244)
  Apply and enforce more ruff rules (zarr-developers#2053)
  ...
@jhamman jhamman added the V3 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman