-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fill_value handling for complex dtypes #2200
Merged
dcherian
merged 12 commits into
zarr-developers:v3
from
dcherian:fix-prop-test-fillvalue
Sep 25, 2024
Merged
Fix fill_value handling for complex dtypes #2200
dcherian
merged 12 commits into
zarr-developers:v3
from
dcherian:fix-prop-test-fillvalue
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
fix-prop-test-fillvalue
branch
from
September 17, 2024 20:27
005279c
to
33f20d3
Compare
jhamman
reviewed
Sep 17, 2024
FWIW the zarr.json is
|
6 tasks
dcherian
force-pushed
the
fix-prop-test-fillvalue
branch
from
September 24, 2024 03:54
566ec13
to
e31cb6f
Compare
dcherian
changed the title
Fix fill_value handling for complex & datetime dtypes
Fix fill_value handling for complex dtypes
Sep 24, 2024
dcherian
force-pushed
the
fix-prop-test-fillvalue
branch
from
September 24, 2024 04:45
1087178
to
2a973b0
Compare
dcherian
commented
Sep 24, 2024
# use array_equal to obtain equal_nan=True functionality | ||
data, other = np.broadcast_arrays(self._data, other) | ||
result = np.array_equal(self._data, other, equal_nan=equal_nan) | ||
result = np.array_equal( | ||
self._data, other, equal_nan=equal_nan if self._data.dtype.kind not in "US" else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needed for V2
normanrz
reviewed
Sep 24, 2024
pre-commit.ci autofix |
jhamman
approved these changes
Sep 25, 2024
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 27, 2024
* v3: (21 commits) Default zarr.open to open_group if shape is not provided (zarr-developers#2158) feat: metadata-only support for storage transformers metadata (zarr-developers#2180) fix(async): set default concurrency to 10 tasks (zarr-developers#2256) chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217) feature(store): add LoggingStore wrapper (zarr-developers#2231) Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259) Add array storage helpers (zarr-developers#2065) Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258) No need to run DeepSource any more - we use ruff (zarr-developers#2261) Remove unnecessary lambda expression (zarr-developers#2260) Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239) Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229) Replace Gitter with Zulip (zarr-developers#2254) Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236) Fix multiple identical imports (zarr-developers#2241) Enforce ruff/flake8-return rules (RET) (zarr-developers#2237) Enforce ruff/flynt rules (FLY) (zarr-developers#2240) Fix fill_value handling for complex dtypes (zarr-developers#2200) Update V2 codec pipeline to use concrete classes (zarr-developers#2244) Apply and enforce more ruff rules (zarr-developers#2053) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out of #2189
TODO: