Enforce ruff/flake8-pytest-style rules (PT) #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PT018 Assertion should be broken down into multiple parts
PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`
PT006 Wrong type passed to first argument of
`@pytest.mark.parametrize`; expected `tuple`
PT003 `scope='function'` is implied in `@pytest.fixture()`
PT001 Use `@pytest.fixture` over `@pytest.fixture()`
jhamman
approved these changes
Sep 25, 2024
d-v-b
pushed a commit
to d-v-b/zarr-python
that referenced
this pull request
Sep 26, 2024
* Apply ruff/flake8-pytest-style rule PT018
PT018 Assertion should be broken down into multiple parts
* Apply ruff/flake8-pytest-style rule PT007
PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`
* Apply ruff/flake8-pytest-style rule PT006
PT006 Wrong type passed to first argument of
`@pytest.mark.parametrize`; expected `tuple`
* Apply ruff/flake8-pytest-style rule PT003
PT003 `scope='function'` is implied in `@pytest.fixture()`
* Apply ruff/flake8-pytest-style rule PT001
PT001 Use `@pytest.fixture` over `@pytest.fixture()`
* Enforce ruff/flake8-pytest-style rules (PT)
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 27, 2024
* v3: (21 commits) Default zarr.open to open_group if shape is not provided (zarr-developers#2158) feat: metadata-only support for storage transformers metadata (zarr-developers#2180) fix(async): set default concurrency to 10 tasks (zarr-developers#2256) chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217) feature(store): add LoggingStore wrapper (zarr-developers#2231) Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259) Add array storage helpers (zarr-developers#2065) Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258) No need to run DeepSource any more - we use ruff (zarr-developers#2261) Remove unnecessary lambda expression (zarr-developers#2260) Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239) Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229) Replace Gitter with Zulip (zarr-developers#2254) Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236) Fix multiple identical imports (zarr-developers#2241) Enforce ruff/flake8-return rules (RET) (zarr-developers#2237) Enforce ruff/flynt rules (FLY) (zarr-developers#2240) Fix fill_value handling for complex dtypes (zarr-developers#2200) Update V2 codec pipeline to use concrete classes (zarr-developers#2244) Apply and enforce more ruff rules (zarr-developers#2053) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: