Move Presence to Document #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yourim Cha <[email protected]>
* Allow users to pass multi nodes when calling Tree.edit * Add nodes validation to Tree.edit
hackerwins
approved these changes
Jul 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 51.50% 51.17% -0.33%
==========================================
Files 67 66 -1
Lines 6932 7006 +74
==========================================
+ Hits 3570 3585 +15
- Misses 2891 2947 +56
- Partials 471 474 +3
|
chacha912
added a commit
that referenced
this pull request
Jul 18, 2023
To ensure atomic delivery of data for `Document` and `Presence` to users, we are removing `Presence` from the `Client` and moving it to the `Document`. In the future, we plan to further modify it by changing `Document` to `Channel` or `Room` and rename `Root` as `Document`. UpdatePresence `UpdatePresence API` has been removed. Now, document and presence changes are transmitted using the `PushPull API`. Consequently, the presence is no longer transmitted as a component of the `Client`, but rather included within the change. ChangePack now contains `presence`. WatchDocument In the `WatchDocument API`, both the request and response only include the client ID, excluding the presence. --------- Co-authored-by: Youngteac Hong <[email protected]>
2 tasks
This was referenced Jul 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move Presence from Client to Document
UpdatePresence
The UpdatePresence API has been removed, and the document and presence changes are now sent through the PushPull API. As a result, the presence is no longer passed as part of the Client but instead included within the change. The changePack now includes the presence.
WatchDocument
In the WatchDocument API, the request and response only include the client ID without the presence.
Which issue(s) this PR fixes:
Address #442
Special notes for your reviewer:
This PR is one of the separations from #542.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: