-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to pass multi nodes when calling Tree.edit #579
Conversation
Codecov Report
@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 51.50% 51.40% -0.10%
==========================================
Files 67 67
Lines 6932 6951 +19
==========================================
+ Hits 3570 3573 +3
- Misses 2891 2907 +16
Partials 471 471
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
I left a comment about style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
* Allow users to pass multi nodes when calling Tree.edit * Add nodes validation to Tree.edit
What this PR does / why we need it:
*TreeNode
=>[]*TreeNode
FYI
Which issue(s) this PR fixes:
Fixes #561
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: