-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Text.select with Presence #583
Comments
I'm interested in this issue. can i work on it? |
@joonhyukchoi sure! give it a try! |
May i ask you a question? If i remove Select in protobuf and reorder tags like below, could there be compatibility issues with before version? i found that compatibility mention in the proto buffer documentation. oneof body { |
@joonhyukchoi Yes. When making that changes to protobuf, there can be compatibility issues with previous versions. In such cases, we have been labeling issues and PRs with |
@chacha912 Thank you. I'll follow that! |
We need to consider two things when modifying Protobuf message: A. Changing the protocol on the API used for communication between the Client and Server: B. Changing the data protocol stored in the database: Since the protocol of the operation has been changed in #589, it applies to both the first and second scenarios mentioned above. Therefore, we also need to consider how to migrate the existing data. |
I'll work on the js sdk |
Description:
Recently we introduced batch updates of documents and presences to provide atomic change delivery and events from
document.subscribe
. All operations and presence changes created indocument.update
guarantee atomic delivery, So we can replaceText.select
with presence and delete the method for now.We need to do the below:
Text.createRange
Text.select
with presence in all Text examplesSelect
operation fromText
Batch updates of documents and presences:
Why:
The text was updated successfully, but these errors were encountered: