-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Select operation from Text #589
Remove Select operation from Text #589
Conversation
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
- Coverage 51.11% 51.06% -0.06%
==========================================
Files 66 66
Lines 7008 6970 -38
==========================================
- Hits 3582 3559 -23
+ Misses 2952 2941 -11
+ Partials 474 470 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I left a comment.
#583 (comment)
The migration appears to be challenging due to operations being stored in a binary format. To accomplish this task, we would need to retrieve operations from DB, unmarshal them using the previous version of the protobuf message and then marshal them again with the new version before storing them back in DB. To avoid the migration process, how about retaining the orders in the protobuf message as they are? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
* Remove Select operation from Text * Retaining the order of protobuf message
What this PR does / why we need it:
Recently we moved presence to document from client and the role of Text.select has become replaceable. So we decided to remove Select operation from Text.
Which issue(s) this PR fixes:
Address #583
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: