Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: indexableに対応 #449

Merged
merged 46 commits into from
Oct 15, 2024
Merged

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Sep 16, 2024

What

検索許可の明示
toot:indexableに対応
検索仕様はmastodon準拠

Why

Resolve #347

Additional info (optional)

つかれた

アカウント削除されたとかのunindex以外確認済み

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net
Copy link
Collaborator Author

あーーー
リアクションやらも過去インデックス張る必要がある

@penginn-net penginn-net marked this pull request as draft September 16, 2024 10:02
@penginn-net
Copy link
Collaborator Author

もうちょっと作業する

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 25.54745% with 612 lines in your changes missing coverage. Please review.

Project coverage is 40.41%. Comparing base (a7b8df8) to head (0ac9427).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 26.66% 473 Missing ⚠️
packages/backend/src/core/QueryService.ts 6.52% 43 Missing ⚠️
...ckend/src/server/api/endpoints/admin/full-index.ts 26.92% 19 Missing ⚠️
...ckages/frontend/src/pages/admin/other-settings.vue 0.00% 17 Missing ⚠️
packages/backend/src/core/ClipService.ts 13.33% 13 Missing ⚠️
...ntend/src/components/MkUserSetupDialog.Privacy.vue 0.00% 10 Missing ⚠️
packages/backend/src/core/ReactionService.ts 20.00% 8 Missing ⚠️
...src/server/api/endpoints/notes/favorites/create.ts 11.11% 8 Missing ⚠️
...ckend/src/server/api/endpoints/notes/polls/vote.ts 12.50% 7 Missing ⚠️
packages/frontend/src/pages/settings/privacy.vue 0.00% 7 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #449       +/-   ##
============================================
+ Coverage    20.23%   40.41%   +20.17%     
============================================
  Files          787     1668      +881     
  Lines       117347   225103   +107756     
  Branches      1088     3833     +2745     
============================================
+ Hits         23744    90970    +67226     
- Misses       93015   133488    +40473     
- Partials       588      645       +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 16, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -13122,6 +13122,31 @@
             "bearerAuth": []
           }
         ],
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "index": {
+                    "type": "string",
+                    "enum": [
+                      "notes",
+                      "reaction",
+                      "pollVote",
+                      "clipNotes",
+                      "Favorites"
+                    ]
+                  }
+                },
+                "required": [
+                  "index"
+                ]
+              }
+            }
+          }
+        },
         "responses": {
           "204": {
             "description": "OK (without any results)"
@@ -50014,6 +50039,9 @@
                   "isExplorable": {
                     "type": "boolean"
                   },
+                  "isIndexable": {
+                    "type": "boolean"
+                  },
                   "hideOnlineStatus": {
                     "type": "boolean"
                   },

Get diff files from Workflow Page

@penginn-net penginn-net changed the title Feat(backend) : indexableに対応 Feat: indexableに対応 Sep 16, 2024
@penginn-net penginn-net added this to the yojo1.1.0 milestone Sep 16, 2024
@penginn-net
Copy link
Collaborator Author

index/unindexをジョブキューに乗せたい
unindexは特に失敗するとよくない

@kozakura913
Copy link
Collaborator

このPRでやると複雑化するし別PRに分割してほしい

Copy link
Collaborator

@jj1guj jj1guj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozakura913
Copy link
Collaborator

通常検索のindexableのテスト無い?

@penginn-net penginn-net mentioned this pull request Sep 30, 2024
4 tasks
@penginn-net penginn-net merged commit 2801c8c into yojo-art:develop Oct 15, 2024
29 of 30 checks passed
@penginn-net penginn-net deleted the indexable branch October 15, 2024 12:50
penginn-net added a commit that referenced this pull request Oct 17, 2024
penginn-net added a commit that referenced this pull request Oct 17, 2024
penginn-net added a commit that referenced this pull request Oct 18, 2024
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toot:indexableに対応
3 participants