Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

高度な検索でリプライ除外にするとエラーがでる #474

Closed
1 task done
penginn-net opened this issue Sep 23, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
🐛bug でたわね
Milestone

Comments

@penginn-net
Copy link
Collaborator

penginn-net commented Sep 23, 2024

💡 概要(Summary)

OpenSearchを利用した高度な検索でリプライ除外をつけるとエラーがでる

🥰 期待する動作(Expected Behavior)

検索できる

🤬 実際の動作(Actual Behavior)

高度な検索でリプライ除外にするとエラーがでる

📝 再現手順(Steps to Reproduce)

No response

💻 動作環境(Frontend Environment)

* Model and OS of the device(s):
* Browser:
* Server URL:
* CherryPick:

🛰 動作環境(サーバー管理者向け)(Backend Environment (for server admin))

* Installation Method or Hosting Service:
* CherryPick:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

このバグを自分で修正しますか?(Do you want to address this bug yourself?)

  • パッチを作成しプルリクエストします(Yes, I will patch the bug myself and send a pull request)
@penginn-net penginn-net added the 🐛bug でたわね label Sep 23, 2024
@penginn-net penginn-net added this to the yojo1.1.0 milestone Sep 23, 2024
@penginn-net penginn-net self-assigned this Sep 23, 2024
@penginn-net
Copy link
Collaborator Author

termとexists間違えてる

if (opts.excludeReply) osFilter.bool.must_not.push({ exists: { isReply: false } });

@kozakura913
Copy link
Collaborator

やっぱテスト必要じゃん

@penginn-net
Copy link
Collaborator Author

if (opts.excludeReply) osFilter.bool.must_not.push({ exists: { isReply: false } });
if (opts.excludeCW) osFilter.bool.must_not.push({ exists: { field: 'cw' } });
if (opts.excludeQuote) osFilter.bool.must.push({ term: { isQuote: false } });

#449 の時に巻き込んでなおしてた

}
if (opts.excludeReply) osFilter.bool.must_not.push({ exists: { field: 'replyId' } });
if (opts.excludeCW) osFilter.bool.must_not.push({ exists: { field: 'cw' } });
if (opts.excludeQuote) osFilter.bool.must.push({ term: { field: 'renoteId' } });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug でたわね
Projects
None yet
Development

No branches or pull requests

2 participants