Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #449 で変えた部分の修正2 #504

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Fix: #449 で変えた部分の修正2

Why

私は要修正箇所を見逃しました

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Oct 17, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (8b0fd6f) to head (353d6fe).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #504       +/-   ##
============================================
- Coverage    62.34%   38.76%   -23.58%     
============================================
  Files          886     1671      +785     
  Lines       108823   220001   +111178     
  Branches      1630     2652     +1022     
============================================
+ Hits         67845    85284    +17439     
- Misses       40957   134107    +93150     
- Partials        21      610      +589     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net merged commit 5f02ee4 into yojo-art:develop Oct 17, 2024
26 of 27 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
@penginn-net penginn-net deleted the fix-2 branch December 7, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants