Do not cast integer as string ids + Fix Zero ID + PHP Coduo #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoanm
commented
May 5, 2023
| @@ -50,11 +50,7 @@ protected function bindIdIfProvided(JsonRpcRequest $request, array $item) : void | |||
| { | |||
| /** If no id defined => request is a notification */ | |||
| if (isset($item[self::KEY_ID])) { | |||
| $request->setId( | |||
| $item[self::KEY_ID] == (string)((int)$item[self::KEY_ID]) | |||
| ? (int)$item[self::KEY_ID] // Convert it in case it's a string containing an int | |||
There was a problem hiding this comment.
Unsure why I did that 🤔 Saw nothing on JSON-RPC specification regarding that point => removed
EDIT: Most likely a matter of typehint, but there is already a check on setId method to ensure id is either a string or an interger
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 170 169 -1
===========================================
Files 28 28
Lines 454 450 -4
===========================================
- Hits 454 450 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yoanm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.