Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for zero IDs; notifications are only NULL #94

Closed
yoanm opened this issue May 6, 2023 · 0 comments · Fixed by #93
Closed

Allow for zero IDs; notifications are only NULL #94

yoanm opened this issue May 6, 2023 · 0 comments · Fixed by #93

Comments

@yoanm
Copy link
Owner

yoanm commented May 6, 2023

From @bradjones1

If a client sends a request with ID -0- (zero) this is converted into a response with ID null, as the check for the presence of an ID in the ResponseCreator is not sufficiently typesafe. The perils of working in PHP, I guess!

I was getting errors on the client side like Received a surprise response from the server with id null after sending such a request ID.
This was linked to pull requests May 6, 2023
Allow for zero IDs; notifications are only NULL #80
Closed
Do not cast integer as string ids + Fix Zero ID + PHP Coduo #93
Merged
yoanm added a commit that referenced this issue May 6, 2023
@yoanm
Fix #94
3b594ab
@yoanm yoanm closed this as completed in #93 May 6, 2023
yoanm added a commit that referenced this issue May 6, 2023
@yoanm @bradjones1
Do not cast integer as string ids + Fix Zero ID + PHP Coduo (#93)
3bd886b 
* Do not cast integer as string ids

* Replace PHPUnit exact match with PHP-coduo

* Allow for zero IDs; notifications are only NULL

* Fix #94

---------

Co-authored-by: Brad Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@yoanm