Allow for zero IDs; notifications are only NULL #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 , just missing an UT case to cover the issue. FYI, PHP is not the issue here, |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 170 170
===========================================
Files 28 28
Lines 454 454
===========================================
Hits 454 454
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
superseded by #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client sends a request with ID -0- (zero) this is converted into a response with ID null, as the check for the presence of an ID in the
ResponseCreatoris not sufficiently typesafe. The perils of working in PHP, I guess!I was getting errors on the client side like
Received a surprise response from the server with id nullafter sending such a request ID.