Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add proper error handling #283

Merged
merged 2 commits into from
Feb 9, 2017
Merged

src: Add proper error handling #283

merged 2 commits into from
Feb 9, 2017

Conversation

GochoMugo
Copy link
Collaborator

  • All tests pass
  • I have run npm run gen-doc

Description

Add proper error handling. Please doc/usage.md for documentation on
error handling.

References

@codecov-io
Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #283 into master will increase coverage by 2.62%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage    88.1%   90.73%   +2.62%     
==========================================
  Files           4        5       +1     
  Lines        1211     1263      +52     
  Branches      239      255      +16     
==========================================
+ Hits         1067     1146      +79     
+ Misses        144      117      -27
Impacted Files Coverage Δ
src/telegramPolling.js 90.6% <93.33%> (+6.52%)
src/telegram.js 89.01% <93.75%> (+1.38%)
src/telegramWebHook.js 95.78% <96.15%> (+2.14%)
src/errors.js 98.66% <97.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5dad6...a3e9923. Read the comment docs.

@GochoMugo GochoMugo force-pushed the feature/error-handling branch from 1c7a02c to f72f45d Compare February 9, 2017 12:49
@GochoMugo GochoMugo merged commit eed7c1e into master Feb 9, 2017
@GochoMugo GochoMugo deleted the feature/error-handling branch February 9, 2017 13:12
GochoMugo added a commit that referenced this pull request Feb 10, 2017
Added:

1. Add constructor options:
  * (#243) `options.polling.params` (by @GochoMugo, requested-by @sidelux)
1. Add methods:
  * (#74) *TelegramBot#removeReplyListener()* (by @githugger)
1. (#283) Add proper error handling (by @GochoMugo)
1. (#272) Add health-check endpoint (by @mironov)
  * `options.webHook.healthEndpoint`
1. (#152) Add test for TelegramBot#sendDocument() using 'fileOpts'
   param (by @evolun)
1. Document `options.webHook.host` (by @GochoMugo)
1. (#264) Add Bot API version to README (by @kamikazechaser)
1. Add examples:
  - (#271) WebHook on Heroku (by @TheBeastOfCaerbannog)
  - (#274) WebHook on Zeit Now (by @ferrari)

Changed:

1. (#147) Use *String#indexOf()*, instead of *RegExp#test()*, to
   find token in webhook request (by @AVVS)

Fixed:

* Fix bug:
  - (#275, #280) fix es6 syntax error on Node.js v4.x (by @CrazyAbdul)
  - (#276) promise.warning from `request-promise` (by @GochoMugo,
    reported-by @preco21)
  - (#281) fix handling error during polling (by @GochoMugo,
    reported-by @dimawebmaker)
  - (#284) fix error during deletion of already-set webhook, during
    polling (by @GochoMugo, reported-by @dcparga)
1. Fix links in documentation (by @Ni2c2k)
@GochoMugo
Copy link
Collaborator Author

Shipped in v0.27.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants