use indexOf to match url #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GochoMugo
requested changes
Nov 10, 2016
| @@ -64,7 +64,7 @@ class TelegramBotWebHook { | |||
| debug('WebHook request headers: %j', req.headers); | |||
|
|
|||
| // If there isn't token on URL | |||
| if (!this.regex.test(req.url)) { | |||
| if (!this.urlValidator(req.url)) { | |||
There was a problem hiding this comment.
Why don't you call indexOf() here, so that it be:
if (req.url.indexOf(this.token) === -1) {Seems simpler and avoids the func call (although the code may be automatically optimized for that, by v8).
|
Done in commit 9d12bdfa41e5f22062543a33cd53798e61dc489f. Thanks @AVVS! |
GochoMugo
added a commit
that referenced
this pull request
Feb 10, 2017
Added: 1. Add constructor options: * (#243) `options.polling.params` (by @GochoMugo, requested-by @sidelux) 1. Add methods: * (#74) *TelegramBot#removeReplyListener()* (by @githugger) 1. (#283) Add proper error handling (by @GochoMugo) 1. (#272) Add health-check endpoint (by @mironov) * `options.webHook.healthEndpoint` 1. (#152) Add test for TelegramBot#sendDocument() using 'fileOpts' param (by @evolun) 1. Document `options.webHook.host` (by @GochoMugo) 1. (#264) Add Bot API version to README (by @kamikazechaser) 1. Add examples: - (#271) WebHook on Heroku (by @TheBeastOfCaerbannog) - (#274) WebHook on Zeit Now (by @ferrari) Changed: 1. (#147) Use *String#indexOf()*, instead of *RegExp#test()*, to find token in webhook request (by @AVVS) Fixed: * Fix bug: - (#275, #280) fix es6 syntax error on Node.js v4.x (by @CrazyAbdul) - (#276) promise.warning from `request-promise` (by @GochoMugo, reported-by @preco21) - (#281) fix handling error during polling (by @GochoMugo, reported-by @dimawebmaker) - (#284) fix error during deletion of already-set webhook, during polling (by @GochoMugo, reported-by @dcparga) 1. Fix links in documentation (by @Ni2c2k)
|
Shipped in v0.27.0. |
GuideUserCom
pushed a commit
to GuideUserCom/TelegramBot-API-Node.js-
that referenced
this pull request
Sep 3, 2024
References: * Original PR: yagop/node-telegram-bot-api#147 * Original Author: @AVVS
passion-27
added a commit
to passion-27/node-telegram-bot
that referenced
this pull request
Oct 2, 2024
References: * Original PR: yagop/node-telegram-bot-api#147 * Original Author: @AVVS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.