Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bot API Version Status Badge #264

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Add Bot API Version Status Badge #264

merged 1 commit into from
Jan 25, 2017

Conversation

kamikazechaser
Copy link
Collaborator

Ref: #260
Info: Displays the Bot API version as a status badge.

@@ -1,3 +1,4 @@
[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://github.com/yagop/node-telegram-bot-api)
[![Build Status](https://travis-ci.org/yagop/node-telegram-bot-api.svg?branch=master)](https://travis-ci.org/yagop/node-telegram-bot-api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent this by one space, please!

@@ -1,3 +1,4 @@
[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://github.com/yagop/node-telegram-bot-api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should point to https://core.telegram.org/bots/api

@GochoMugo GochoMugo added the docs label Jan 23, 2017
@@ -1,5 +1,5 @@
[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://github.com/yagop/node-telegram-bot-api)
[![Build Status](https://travis-ci.org/yagop/node-telegram-bot-api.svg?branch=master)](https://travis-ci.org/yagop/node-telegram-bot-api)
[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://core.telegram.org/bots/api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, the 1st line is not indented!

[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://github.com/yagop/node-telegram-bot-api)
[![Build Status](https://travis-ci.org/yagop/node-telegram-bot-api.svg?branch=master)](https://travis-ci.org/yagop/node-telegram-bot-api)
[![Bot API](http://img.shields.io/badge/Bot API-v2.3.1-00aced.svg?style=flat-square)](https://core.telegram.org/bots/api)
[![Build Status](https://travis-ci.org/yagop/node-telegram-bot-api.svg?branch=master)](https://travis-ci.org/yagop/node- telegram-bot-api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some space after node- in the link?

@kamikazechaser
Copy link
Collaborator Author

Fixed indentation and changed re-direct url

@GochoMugo GochoMugo merged commit 235ea22 into yagop:master Jan 25, 2017
GochoMugo added a commit that referenced this pull request Feb 10, 2017
Added:

1. Add constructor options:
  * (#243) `options.polling.params` (by @GochoMugo, requested-by @sidelux)
1. Add methods:
  * (#74) *TelegramBot#removeReplyListener()* (by @githugger)
1. (#283) Add proper error handling (by @GochoMugo)
1. (#272) Add health-check endpoint (by @mironov)
  * `options.webHook.healthEndpoint`
1. (#152) Add test for TelegramBot#sendDocument() using 'fileOpts'
   param (by @evolun)
1. Document `options.webHook.host` (by @GochoMugo)
1. (#264) Add Bot API version to README (by @kamikazechaser)
1. Add examples:
  - (#271) WebHook on Heroku (by @TheBeastOfCaerbannog)
  - (#274) WebHook on Zeit Now (by @ferrari)

Changed:

1. (#147) Use *String#indexOf()*, instead of *RegExp#test()*, to
   find token in webhook request (by @AVVS)

Fixed:

* Fix bug:
  - (#275, #280) fix es6 syntax error on Node.js v4.x (by @CrazyAbdul)
  - (#276) promise.warning from `request-promise` (by @GochoMugo,
    reported-by @preco21)
  - (#281) fix handling error during polling (by @GochoMugo,
    reported-by @dimawebmaker)
  - (#284) fix error during deletion of already-set webhook, during
    polling (by @GochoMugo, reported-by @dcparga)
1. Fix links in documentation (by @Ni2c2k)
@kamikazechaser kamikazechaser deleted the patch-1 branch February 10, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants