Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear glyph pixels when all channels differ below a threshold #3897

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 10, 2022

Fixes #3892
Also helps with #3877

Before:

image
image

After:

image
image

Main differences:

  • A pixel in the top left of W in "WARN" is gone
  • A pixel in the bottom right of k in "Work"
  • Some of the AA around the green text on yellow text disappears, zoomed out I can't see a difference on 1080p 24" monitor

I tried initially by checking the contrast ratio which is relatively expensive to calculate and we would also need to compare the hue in that case.

@Tyriar Tyriar added this to the 4.20.0 milestone Jul 10, 2022
@Tyriar Tyriar requested a review from meganrogge July 10, 2022 14:29
@Tyriar Tyriar self-assigned this Jul 10, 2022
@Tyriar Tyriar marked this pull request as draft July 10, 2022 15:29
@Tyriar Tyriar marked this pull request as ready for review July 10, 2022 15:49
@Tyriar Tyriar changed the title Clear glyph pixels when all channels differ < 35 Clear glyph pixels when all channels differ below a threshold Jul 11, 2022
@Tyriar Tyriar merged commit 6b44795 into xtermjs:master Jul 11, 2022
@Tyriar Tyriar deleted the 3892 branch July 11, 2022 19:06
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pixels from glyph that are below some threshold of difference to the background color
2 participants