Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pixels from glyph that are below some threshold of difference to the background color #3892

Closed
Tyriar opened this issue Jul 7, 2022 · 0 comments · Fixed by #3897
Closed

Remove pixels from glyph that are below some threshold of difference to the background color #3892

Tyriar opened this issue Jul 7, 2022 · 0 comments · Fixed by #3897
Assignees
@Tyriar
Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

This bad overlapping can occur sometimes:

Screen Shot 2022-07-07 at 10 58 29 am

I think this is because the white pixels don't match the background exactly but are close enough to it that they should be treated as transparent.
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Clear glyph pixels when all channels differ < 35
3440ceb 
Fixes xtermjs#3892
Also helps with xtermjs#3877
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Clear glyph pixels when all channels differ < 35
89b320a 
Fixes xtermjs#3892
Also helps with xtermjs#3877
This was referenced Jul 10, 2022
Merged
Closed
@Tyriar Tyriar self-assigned this Jul 10, 2022
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 10, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Clear glyph pixels when all channels differ below a threshold Tyriar/xterm.js
1 participant
@Tyriar