Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webgl renderer cells can look wrong when adjacent cells differ in background color #3877

Closed
Tyriar opened this issue Jun 27, 2022 · 0 comments · Fixed by #3896
Closed

Webgl renderer cells can look wrong when adjacent cells differ in background color #3877

Tyriar opened this issue Jun 27, 2022 · 0 comments · Fixed by #3896
Assignees
@Tyriar
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2022

This is one of the worst cases this could happen in:

image
image

Note that it doesn't actually happen in canvas renderer.
@Tyriar Tyriar added type/bug Something is misbehaving area/addon/webgl labels Jun 27, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Clip pixels to left of cell when background color changes
5e8133b 
Fixes xtermjs#3877
@Tyriar Tyriar mentioned this issue Jul 10, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Clear glyph pixels when all channels differ < 35
3440ceb 
Fixes xtermjs#3892
Also helps with xtermjs#3877
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar
Clear glyph pixels when all channels differ < 35
89b320a 
Fixes xtermjs#3892
Also helps with xtermjs#3877
@Tyriar Tyriar mentioned this issue Jul 10, 2022
Merged
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 10, 2022
@Tyriar Tyriar self-assigned this Jul 10, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Clip pixels to left of cell when background color changes Tyriar/xterm.js
1 participant
@Tyriar