xarray dependency adjusted in pyproject.toml #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails due to other tests, which are not related to this PR. |
pont-us
reviewed
Jan 2, 2025
pyproject.toml
Outdated
| @@ -55,7 +55,7 @@ dependencies = [ | |||
| "tabulate>=0.9", | |||
| "tornado>=6.0", | |||
| "urllib3>=1.26", | |||
| "xarray>=2022.6,<=2024.6", | |||
| "xarray>=2022.6", | |||
There was a problem hiding this comment.
Suggested change
| "xarray>=2022.6", | |
| "xarray>=2024.7", |
The updated test will of course fail for any xarray version under 2024.7, so we need to update the minimum version. Alternatively we could have the test change its behaviour depending on the xarray version, but I think there's no harm in bumping the dependency specification.
(And the same goes for the xarray specification in environment.yml.)
There was a problem hiding this comment.
Changes applied in pyproject.toml and environement.yml.
|
Fixes #1094 |
konstntokas
force-pushed
the
konstntokas-xxx-adjust_xarray_dependency
branch
from
32bbb1d to
8ad5f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1094
In #1068 xcube has been adjusted so that it is complient to
xarray >=2024.6. However, I forgot to adjustpyproject.toml.Note that
xarray.core.resample.DataArrayResample.quantilenow allows dask arrays. Therefore, the test inresample_in_timewas adjusted. This is related to the new feature in xarray 2024.7 (https://docs.xarray.dev/en/stable/whats-new.html#id40) and the PR pydata/xarray#9109.Checklist:
Add docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*Changes documented inCHANGES.md