Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rechunking to a frequency. #9109

Merged
merged 12 commits into from
Jul 29, 2024
Merged

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jun 12, 2024

Now uses syntax ds.chunk(time=TimeResampler("YE"))

@shoyer
Copy link
Member

shoyer commented Jun 13, 2024

Are frequency strings unambiguous? Rechunking already supports memory sizes for Dask using strings.

@dcherian dcherian marked this pull request as draft June 13, 2024 17:55
@dcherian dcherian force-pushed the chunk-by-frequency branch from 566fd37 to 5ffb9e4 Compare June 22, 2024 02:48
@dcherian dcherian force-pushed the chunk-by-frequency branch from 5ffb9e4 to e38a9b9 Compare July 18, 2024 04:15
@dcherian dcherian marked this pull request as ready for review July 18, 2024 07:31
@dcherian
Copy link
Contributor Author

Ready for review!

The syntax is ds.chunk(time=TimeResampler("YE")).

dcherian added 4 commits July 18, 2024 13:08
* main:
  Delete ``base`` and ``loffset`` parameters to resample (pydata#9233)
  Update dropna docstring (pydata#9257)
@dcherian
Copy link
Contributor Author

This is pretty cool, and could use a review!

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @dcherian! My only suggestion is to make the documentation a little clearer about how to import the TimeResampler object.

doc/user-guide/dask.rst Outdated Show resolved Hide resolved
doc/user-guide/dask.rst Show resolved Hide resolved
Co-authored-by: Spencer Clark <[email protected]>
@dcherian dcherian merged commit af12604 into pydata:main Jul 29, 2024
28 checks passed
@dcherian dcherian deleted the chunk-by-frequency branch July 29, 2024 17:38
dcherian added a commit to dcherian/xarray that referenced this pull request Jul 29, 2024
* main:
  automate extracting the contributors (pydata#9288)
  Support rechunking to a frequency. (pydata#9109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying chunk sizes using labels (e.g. frequency string)
3 participants