Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_resample_in_time_p90_dask failing #1094

Closed
pont-us opened this issue Dec 3, 2024 · 0 comments · Fixed by #1099
Closed

test_resample_in_time_p90_dask failing #1094

pont-us opened this issue Dec 3, 2024 · 0 comments · Fixed by #1099

Comments

@pont-us
Copy link
Member

pont-us commented Dec 3, 2024

The unit test test_resample_in_time_p90_dask fails with xarray 2024.11.0.

The critical line in the test:

            resampled_cube = resample_in_time(self.input_cube, "2W", "percentile_90")

The test expects this to throw an exception. Under Linux, with xarray versions prior to 2024.11.0, the following exception is thrown so the test passes:

ValueError: dimension time on 0th function argument to apply_ufunc with dask='parallelized' consists of multiple chunks, but is also a core dimension. To fix, either rechunk into a single array chunk along this dimension, i.e., ``.chunk(dict(time=-1))``, or pass ``allow_rechunk=True`` in ``dask_gufunc_kwargs`` but beware that this may significantly increase memory usage.

With xarray 2024.11.0, no exception is thrown. It may simply be that xarray now allows multi-chunk core dimensions, but we should confirm that before rewriting or deleting the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant