Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps to pre-commit mypy and fix issues #191

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 13, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added type: enhancement New enhancement request type: devops Testing, CI/CD, systems configuration Priority: High labels Jan 13, 2022
@tomvothecoder tomvothecoder self-assigned this Jan 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #191 (27075ab) into main (201a575) will decrease coverage by 0.47%.
The diff coverage is 97.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #191      +/-   ##
===========================================
- Coverage   100.00%   99.52%   -0.48%     
===========================================
  Files            8        8              
  Lines          381      421      +40     
===========================================
+ Hits           381      419      +38     
- Misses           0        2       +2     
Impacted Files Coverage Δ
xcdat/spatial_avg.py 98.86% <91.66%> (-1.14%) ⬇️
xcdat/__init__.py 100.00% <100.00%> (ø)
xcdat/axis.py 100.00% <100.00%> (ø)
xcdat/bounds.py 100.00% <100.00%> (ø)
xcdat/dataset.py 100.00% <100.00%> (ø)
xcdat/xcdat.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71f466...27075ab. Read the comment docs.

@tomvothecoder tomvothecoder merged commit 2b639a1 into main Jan 13, 2022
@tomvothecoder tomvothecoder deleted the devops/190-mypy-precommit branch January 13, 2022 22:37
@tomvothecoder tomvothecoder restored the devops/190-mypy-precommit branch January 13, 2022 22:37
@tomvothecoder tomvothecoder deleted the devops/190-mypy-precommit branch January 18, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: devops Testing, CI/CD, systems configuration type: enhancement New enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add dependencies to pre-commit mypy hook and fix issues
2 participants