Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Add dependencies to pre-commit mypy hook and fix issues #190

Closed
tomvothecoder opened this issue Jan 13, 2022 · 0 comments · Fixed by #191
Closed

[FEATURE]: Add dependencies to pre-commit mypy hook and fix issues #190

tomvothecoder opened this issue Jan 13, 2022 · 0 comments · Fixed by #191
Assignees
Labels
type: devops Testing, CI/CD, systems configuration type: enhancement New enhancement request

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Jan 13, 2022

Is your feature request related to a problem?

I noticed that (1) mypy xcdat and (2) pre-commit run mypy --all-files produce different results.
I learned that (2) runs in an isolated virtualenv without dependencies installed, so we must add an array of dependencies in the additional_dependencies settings under .pre-commit-config.yaml to capture a complete log of issues.

More info: pre-commit/pre-commit#1580 (comment)

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: devops Testing, CI/CD, systems configuration type: enhancement New enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant