Initial Port of Jetpack Tiled Gallery Block #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wendy Chen <[email protected]>
Tiled Gallery needed to be mocked
…k-registration Register Jetpack Tiled Gallery block
…k-inner-blocks Jetpack Tiled Gallery: Inner blocks implementation Co-authored-by: Wendy Chen <[email protected]>
…k-settings Jetpack Tiled Gallery: Settings implementation
Jetpack Tiled Gallery Block: Hooking up settings with attributes on block
…ursion bug needs further investigation.
|
@SiobhyB I added the 1.70.0 milestone (due next Thursday), since we hope to have an approval on the Jetpack PR by then. I figured we can always change this later if needed, but let me know if you think otherwise. |
|
Sounds good to me @guarani! |
|
Hey @SiobhyB, we will cut the |
SiobhyB
added
Tiled Gallery block
guarani
approved these changes
Jan 19, 2022
It was hard-coded to `true`. Fixed by using capability variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4268
Related PRs
To test
Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.
Bundle changes
Note, a number of
jsonfiles were removed after runningnpm run bundleon this PR. This was expected following the recent upgrade to React Native 0.66. Alljsonfiles are no longer created under the bundle folder because their content is already being injected into the JS bundle code, so those files are redundant.The removal of the files was reverted for this PR, however. This is so that their removal can be more formally tested/approved in #4401.
PR submission checklist