Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Tiled Gallery: Settings implementation #4015

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Jetpack Tiled Gallery: Settings implementation #4015

merged 2 commits into from
Sep 23, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Sep 23, 2021

Fixes #3947

To test, see Automattic/jetpack#21028.

PR submission checklist:

  • I have considered adding unit tests where possible.
    • I think integration tests can be added later.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani added [Type] Enhancement Improves a current area of the editor Jetpack Bug or feature related to Jetpack labels Sep 23, 2021
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani changed the title Update Jetpack submodule ref Jetpack Tiled Gallery: Settings implementation Sep 23, 2021
@guarani guarani requested a review from illusaen September 23, 2021 03:19
@SiobhyB SiobhyB self-requested a review September 23, 2021 09:36
SiobhyB
SiobhyB approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the PR's referencing the already merged Jetpack code (4c3ebd7ceb6a72879d6320ab94495f696b9a0660).

@guarani guarani merged commit 769e7f5 into add/tiled-gallery-block Sep 23, 2021
@guarani guarani deleted the add/tiled-gallery-block-settings branch September 23, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@illusaen illusaen Awaiting requested review from illusaen

Assignees
No one assigned
Labels
Jetpack Bug or feature related to Jetpack [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guarani @SiobhyB