Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Port of Jetpack Tiled Gallery Block #17618

Merged
merged 13 commits into from
Jan 19, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Dec 3, 2021

Fixes wordpress-mobile/gutenberg-mobile#4268

This PR brings the first iteration of the Tiled Gallery block to the iOS app.

To test: Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.

Related PRs

Regression Notes

  1. Potential unintended areas of impact

This PR adds a new block, and it is only available on development builds, so there is little potential impact on other parts of the app.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

We just relied on existing Gutenberg Mobile and WPiOS tests.

  1. What automated tests I added (or what prevented me from doing so)

We added a test in wordpress-mobile/gutenberg-mobile#3903 but wordpress-mobile/gutenberg-mobile#4168 needs to be resolved before we can add more tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 3, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@SiobhyB SiobhyB added Gutenberg Editing and display of Gutenberg blocks. Posting/Editing Media labels Dec 3, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 3, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Siobhan added 2 commits December 3, 2021 14:07
In all other lists, references to the tiled gallery block are positioned beneath the layout grid block. This commit updates the one case where this isn't true, for consistency.
@guarani guarani self-requested a review January 13, 2022 19:32
@guarani guarani marked this pull request as ready for review January 13, 2022 19:32
@guarani guarani added this to the 19.1 milestone Jan 18, 2022
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change by loading the Square layout and things are working as expected, so I'm approving this now.

I added the DO NOT merge label because:

  • The linked Jetpack PR needs to be merged first
  • Then the Gutenberg Mobile PR (and Gutenberg PR) need to be merged and a tagged release created

I also added the next milestone since we hope to get this merged soon. I also intentionally did not add release notes, since this block will only be available when connecting to the Metro server running out of the Gutenberg Mobile repo.

@guarani guarani enabled auto-merge January 19, 2022 21:16
@guarani guarani merged commit 7016b46 into trunk Jan 19, 2022
@guarani guarani deleted the gutenberg/add/tiled-gallery-block branch January 19, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Media Posting/Editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Jetpack Phase 1B feature branch into master
2 participants