-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Port of Jetpack Tiled Gallery Block #17618
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
In all other lists, references to the tiled gallery block are positioned beneath the layout grid block. This commit updates the one case where this isn't true, for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change by loading the Square layout and things are working as expected, so I'm approving this now.
I added the DO NOT merge label because:
- The linked Jetpack PR needs to be merged first
- Then the Gutenberg Mobile PR (and Gutenberg PR) need to be merged and a tagged release created
I also added the next milestone since we hope to get this merged soon. I also intentionally did not add release notes, since this block will only be available when connecting to the Metro server running out of the Gutenberg Mobile repo.
Fixes wordpress-mobile/gutenberg-mobile#4268
This PR brings the first iteration of the Tiled Gallery block to the iOS app.
To test: Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.
Related PRs
Regression Notes
This PR adds a new block, and it is only available on development builds, so there is little potential impact on other parts of the app.
We just relied on existing Gutenberg Mobile and WPiOS tests.
We added a test in wordpress-mobile/gutenberg-mobile#3903 but wordpress-mobile/gutenberg-mobile#4168 needs to be resolved before we can add more tests.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.