Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Onboarding: "The Basics" help section - Details Part 2 #3824

Merged
merged 18 commits into from
Aug 19, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 11, 2021

Related PRs

Relates to WordPress/gutenberg#30626. Iterates upon the work completed in WordPress/gutenberg#33790. This work improves accessibility, copy, and design of the editor help section.

To test: See WordPress/gutenberg#34018

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added the [Type] Enhancement Improves a current area of the editor label Aug 11, 2021
@dcalhoun dcalhoun self-assigned this Aug 11, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 11, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Includes new image assets for help sections.
@dcalhoun dcalhoun force-pushed the update/editor-onboarding-help-detail-view branch from 8c0062a to 28232e2 Compare August 11, 2021 19:47
@dcalhoun dcalhoun added this to the 1.60.0 (18.1) milestone Aug 11, 2021
@dcalhoun dcalhoun marked this pull request as ready for review August 11, 2021 21:25
@dcalhoun dcalhoun requested a review from jhnstn August 11, 2021 21:26
Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dcalhoun dcalhoun enabled auto-merge August 19, 2021 01:14
@AmandaRiu
Copy link
Contributor

Nice work @dcalhoun !

Attempt to have "Check Correctness" CI job pass, which is currently
failing with `cb() never called` errors.
Attempt to have "Correctness Check" CI task pass, which is currently
failing with `cb() never called errors`.
Attempt to have "Correctness Check" CI task pass, which is currently
failing with `cb() never called errors`.
Attempt to have "Correctness Check" CI task pass, which is currently
failing with `cb() never called errors`.
Attempt to have "Correctness Check" CI task pass, which is currently
failing with `cb() never called errors`.
@dcalhoun dcalhoun merged commit d8763e8 into develop Aug 19, 2021
@dcalhoun dcalhoun deleted the update/editor-onboarding-help-detail-view branch August 19, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants