-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor Onboarding: "The Basics" help section - Details Part 2 #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
4 tasks
Includes new image assets for help sections.
dcalhoun
force-pushed
the
update/editor-onboarding-help-detail-view
branch
from
August 11, 2021 19:47
8c0062a
to
28232e2
Compare
3 tasks
jhnstn
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…e into update/editor-onboarding-help-detail-view
Nice work @dcalhoun ! |
Attempt to have "Check Correctness" CI job pass, which is currently failing with `cb() never called` errors.
Attempt to have "Correctness Check" CI task pass, which is currently failing with `cb() never called errors`.
Attempt to have "Correctness Check" CI task pass, which is currently failing with `cb() never called errors`.
This reverts commit a871219.
This reverts commit 5a6015e.
This reverts commit f9d94f4.
Attempt to have "Correctness Check" CI task pass, which is currently failing with `cb() never called errors`.
This reverts commit 387c104.
Attempt to have "Correctness Check" CI task pass, which is currently failing with `cb() never called errors`.
This reverts commit 8d0afb8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Relates to WordPress/gutenberg#30626. Iterates upon the work completed in WordPress/gutenberg#33790. This work improves accessibility, copy, and design of the editor help section.
To test: See WordPress/gutenberg#34018
PR submission checklist: