[RNMobile] Editor Onboarding: "The Basics" help section - Details Part 1 #33790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AmandaRiu
added
the
Mobile App - i.e. Android or iOS
|
Size Change: -453 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
dcalhoun
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
This looks good, @AmandaRiu! Thank you for putting this work together. I verified the feature works as expected on an iPhone SE and Samsung Galaxy S20.
I agree that a fullscreen bottom sheet likely makes a lot of sense. Currently, the help section title and back button scrolls out of view when viewing longer content. Losing visibility of the back button in particular feels odd and disorienting. Hopefully we can improve this aspect in future work.
Scrolling Hides Back Button
I left a few comments that are not blockers. We could always address them in future PRs if desired.
packages/editor/src/components/editor-help/add-blocks.native.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/editor-help/help-detail-navigation-screen.native.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/editor-help/view-sections.native.js
Outdated
Show resolved
Hide resolved
This was referenced Aug 2, 2021
Loading local static assets from a different package within a monorepo appears broken in Metro for Android. The below fixes paths to packages within this project to include the necessary `/assets/..` that Metro's server expects to traverse to the correct directory. - https://git.io/JBV4e - https://git.io/JBFon
This was referenced Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3777
Description
This PR is the second in a series of PRs to add the Editor Onboarding basic help section defined in this ticket: #30626 and covers the following:
Note that this PR only covers a baseline for this area of the feature and will continue to be iterated on by another developer. I'm opening this PR now to ensure the work done so far so it can neatly be handed off to the next developer as I'll be moving projects.
Special notes:
BottomSheet.SubSheetfor the details pages, but for some reason the images would flicker uncontrollably while scrolling on iOS. I attempted to useuseMemoto prevent this, but couldn't get it to work. For that reason I went back to my original custom implementation ofBottomSheet.NavigationScreenand useuseMemoinview-section.native.jswhen serving up the image assets to avoid rerendering images while scrolling. This works nicely. Below are recordings of the iOS differences.The "before" is using
BottomSheet.SubSheet:subsheet.mp4
After is using the custom
BottomSheet.NavigationSheet:old-sheet.mp4
How has this been tested?
Screenshots
Screen-Recording-2021-07-31-at-5.13.57-AM.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).