Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable editor help menu for eligible users #15164

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Enable editor help menu for eligible users #15164

merged 4 commits into from
Aug 19, 2021

Conversation

dcalhoun
Copy link
Member

Related PRs

To test: See WordPress/gutenberg#34018.

Regression Notes

  1. Potential unintended areas of impact
    Changes to the feature flag could disrupted existing flagged features.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested a few of the feature flag feature to ensure they functioned as expected.
  3. What automated tests I added (or what prevented me from doing so)
    Decided automated tests in this repository were not valuable for this Gutenberg-centric change.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun
Enable editor help menu for eligible users
82f013a 
Display the editor help menu for users who belong to the testing cohort.
@dcalhoun
Update gutenbergMobileVersion ref
996619a
@dcalhoun dcalhoun added this to the 18.1 milestone Aug 11, 2021
@dcalhoun dcalhoun self-assigned this Aug 11, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 11, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced Aug 11, 2021
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 11, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

@dcalhoun dcalhoun marked this pull request as ready for review August 11, 2021 21:25
@dcalhoun dcalhoun requested a review from jhnstn August 11, 2021 21:26
jhnstn
jhnstn approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through the test steps in the companion Gutenberg PR and everything works as expected 👍

@dcalhoun dcalhoun merged commit 285f170 into develop Aug 19, 2021
@dcalhoun dcalhoun deleted the update/enable-editor-help-menu branch August 19, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnstn jhnstn jhnstn approved these changes

Assignees

@dcalhoun dcalhoun

Labels
[Type] Enhancement
Projects
None yet
Milestone
18.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @jhnstn