Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Layout Picker #2921

Merged
merged 12 commits into from
Jan 8, 2021
Merged

Remove old Layout Picker #2921

merged 12 commits into from
Jan 8, 2021

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Dec 21, 2020

Fixes #2936

Gutenberg PR -> WordPress/gutenberg#27640
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#15550
WordPress Android PR -> wordpress-mobile/WordPress-Android#13665

Removes unused code of the page layout picker. A native layout picker was implemented in the WordPress apps so this is no longer being used.

It updates the bundles since it involves native changes.

To test check the Gutenberg PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux force-pushed the remove-old-layout-picker branch from 6bab896 to 4fc346e Compare December 23, 2020 10:01
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 23, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the remove-old-layout-picker branch from 4fc346e to bdd107b Compare December 28, 2020 13:20
@geriux geriux force-pushed the remove-old-layout-picker branch from bdd107b to 18fc6b6 Compare December 29, 2020 09:36
@geriux geriux requested review from antonis and chipsnyder December 29, 2020 10:22
@geriux geriux marked this pull request as ready for review December 29, 2020 10:22
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux geriux force-pushed the remove-old-layout-picker branch from 18fc6b6 to 7f2d015 Compare January 7, 2021 15:59
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux geriux force-pushed the remove-old-layout-picker branch 2 times, most recently from c2719e2 to 82b98de Compare January 8, 2021 12:20
@geriux geriux merged commit 4bac2ec into develop Jan 8, 2021
@geriux geriux deleted the remove-old-layout-picker branch January 8, 2021 14:54
@geriux geriux mentioned this pull request Jan 13, 2021
2 tasks
@cameronvoell cameronvoell added this to the 1.45 (16.6) milestone Jan 19, 2021
@cameronvoell cameronvoell mentioned this pull request Jan 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old Page Layout Picker
4 participants