-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Layout Picker #2921
Merged
Merged
Remove old Layout Picker #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gutenberg
This was referenced Dec 21, 2020
[Gutenberg] - Remove tooltip flag and modal layout feature flag
wordpress-mobile/WordPress-iOS#15550
Merged
geriux
force-pushed
the
remove-old-layout-picker
branch
from
December 23, 2020 10:01
6bab896
to
4fc346e
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
3 tasks
geriux
force-pushed
the
remove-old-layout-picker
branch
from
December 28, 2020 13:20
4fc346e
to
bdd107b
Compare
geriux
force-pushed
the
remove-old-layout-picker
branch
from
December 29, 2020 09:36
bdd107b
to
18fc6b6
Compare
antonis
approved these changes
Dec 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with WordPress/gutenberg#27640 (review)
geriux
force-pushed
the
remove-old-layout-picker
branch
from
January 7, 2021 15:59
18fc6b6
to
7f2d015
Compare
chipsnyder
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geriux
force-pushed
the
remove-old-layout-picker
branch
2 times, most recently
from
January 8, 2021 12:20
c2719e2
to
82b98de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2936
Gutenberg PR
-> WordPress/gutenberg#27640WordPress iOS PR
-> wordpress-mobile/WordPress-iOS#15550WordPress Android PR
-> wordpress-mobile/WordPress-Android#13665Removes unused code of the page layout picker. A native layout picker was implemented in the WordPress apps so this is no longer being used.
It updates the bundles since it involves native changes.
To test check the Gutenberg PR
PR submission checklist: