Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.45.0 #3021

Merged
merged 92 commits into from
Jan 21, 2021
Merged

Release 1.45.0 #3021

merged 92 commits into from
Jan 21, 2021

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jan 18, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.45.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

ceyhun and others added 30 commits November 30, 2020 20:14
@ceyhun
Update gutenberg ref
9daacda
@ceyhun
Merge branch 'develop' into add/block-insertion-flow-e2e
8099e5d
@ceyhun
Revert jetpack ref
4249205
@ceyhun
Update gutenberg ref
3d09b5d
@ceyhun
Use testPathPattern to skip environment setup on skipped tests
53d93f4
@ceyhun
Update gutenberg ref
89570bc
@ceyhun
Merge branch 'develop' into add/block-insertion-flow-e2e
abb24cc
@ceyhun
Update gutenberg ref
6c8f9f0
@mkevins
Update gutenberg reference
926ff20
@mkevins
Update gutenberg reference
5d4b918
@mkevins
Update gutenberg reference
a7d930f
@mkevins
Update gutenberg reference
f48898a
@mkevins
Update gutenberg reference
59ced35
@mkevins
Add release note
d8a84a4
WC: Adding UI tests.
42d753f
WC: Fixing UI tests for move block to top/bottom.
c3bd1a4
WC: Moving block mover UI tests to gutenberg with others.
fc69e9e
WC: Changing hash to bring in gutenberg changes for block mover.
6ea9c94
@cameronvoell
Temporarily update submodule reference to point to illusaen fork for …
1790f60 
…testing
WC: Reveting gitmodules to original and updating gutenberg hash.
675e2cc
@cameronvoell
Merge pull request #2872 from wordpress-mobile/issue-1191-add-move-to…
a53c06d 
…-top-bottom

Adding block moving to top and to bottom functionality.
@ceyhun
t
b3b9c6a 
Update gutenberg ref
@ceyhun
Merge branch 'develop' into add/block-insertion-flow-e2e
aee0b29
@ceyhun
Update package-lock.json
dca7de9
@ceyhun
Update package-lock.json
f76077a
@hypest
Bump Gutenberg ref
cd74d02
@hypest
Update package-lock.json
ceaddbe
@hypest
Commit package lock change after additional npm install run
7589573
@ceyhun
Remove and re-add @wordpress/eslint-plugin to fix missing plugin errors
23e109c
@ceyhun
Resolve packages inside gutenberg and gutenberg/node_modules as well
6990c57
dependabot bot and others added 11 commits January 18, 2021 07:50
@dependabot
Bump gutenberg from 6f8a34c to 9f7d9e7
85cbadf 
Bumps [gutenberg](https://github.com/WordPress/gutenberg) from `6f8a34c` to `9f7d9e7`.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Commits](WordPress/gutenberg@6f8a34c...9f7d9e7)

Signed-off-by: dependabot[bot] <[email protected]>
@fluiddot
Update Gutenberg submodule
caec4b8
@cameronvoell
Updated gutenberg ref
427a51d
@cameronvoell
Merge branch 'develop' into merge_release_1.44.1_to_develop
bc82f0b
@cameronvoell
Updated gutenberg ref
78cd849
@cameronvoell
Merge pull request #3014 from wordpress-mobile/dependency/bump-gutenb…
c73ba02 
…erg-82bdf9d

Bump Gutenberg submodule and fix List block's e2e test
@cameronvoell
Merge branch 'develop' into merge_release_1.44.1_to_develop
1ab6d76
@cameronvoell
Merge pull request #3016 from wordpress-mobile/merge_release_1.44.1_t…
2bcc59a 
…o_develop

Merge release 1.44.1 to develop
@cameronvoell
Release script: Update gb mobile version to 1.45.0
b3154f4
@cameronvoell
Release script: Update gutenberg ref
bc1bfe5
@cameronvoell
Release script: Update bundle for: 1.45.0
de980f0
This was referenced Jan 18, 2021
Merged
Merged
Merged
@cameronvoell cameronvoell requested a review from illusaen January 19, 2021 03:27
@cameronvoell cameronvoell marked this pull request as ready for review January 19, 2021 03:27
@antonis
Copy link

antonis commented Jan 19, 2021 •
edited
Loading

iOS: Test Suite 3

Tested build 40605 from AppCenter on an iPhone SE 2020 with iOS 14.2

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
    - Break line details: -> This is no longer true. Updated test case with wordpress-mobile/test-cases@083ba4d
    • Break lines don't work in the middle of the captions.
    • If you do a break at the end of the Gallery caption, it will insert a new paragraph bellow the block.
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
    • If I edit the block (e.g. add caption) and hit Update, I get a Problem displaying block. If I close and reopen the post, the cover block video renders correctly. The same issue seem to occur in all edits. => Opened issue
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Switch to classic editor with an image block in page - TC006
  • Image block - Border style setting - TC007
  • Image block - Image size setting - TC008
  • Image block - Link to setting - TC009

@illusaen
Copy link
Contributor

iOS: Writing Flow checklist

Tested on iPhone 12 Mini, iOS 14.3

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@cameronvoell
Copy link
Contributor Author

Android: Writing Flow checklist 🟢

Tested on Samsung Galaxy Tab S3 ; Android 9

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dratwas
Copy link
Contributor

dratwas commented Jan 20, 2021 •
edited
Loading

Tested on Pixel 3 Android 10

DarkMode-2

  • Spacer block - Dark mode - steps
  • Buttons block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-2

  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

Buttons-4

  • Buttons block - Render custom text color - steps
  • Buttons block - Render custom background color - steps
  • Buttons block - Render gradient background color - steps
  • Buttons block - Check if selection / caret color matches font color - steps
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Buttons-5

  • Buttons block - Edit text styles - steps
  • Buttons block - Render theme colors - steps
  • Buttons block - Settings: Change Button border radius - steps

Buttons-7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Buttons block - Toolbar link button is active when Button has link - steps

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - steps
  • Offline Support - steps

Color Settings - 2

  • Pressing color swatch - steps
  • Customize gradient color - steps
  • Custom color picker - steps

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 21, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

illusaen
illusaen approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@illusaen illusaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks green, bundle updated.

@illusaen illusaen merged commit ddbed41 into trunk Jan 21, 2021
@illusaen illusaen deleted the release/1.45.0 branch January 21, 2021 18:02
This was referenced Jan 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illusaen illusaen illusaen approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.