Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] - Remove tooltip flag and modal layout feature flag #15550

Merged
merged 11 commits into from
Jan 13, 2021

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Dec 21, 2020

Gutenberg PR -> WordPress/gutenberg#27640
Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2921
WordPress Android PR -> wordpress-mobile/WordPress-Android#13665

Removes unused code of the old page layout picker.

Old picker New picker

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added [Status] In Progress Gutenberg Editing and display of Gutenberg blocks. labels Dec 21, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 21, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 21, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Gerardo Pacheco added 3 commits December 28, 2020 14:34
# Conflicts:
#	Podfile
#	Podfile.lock
#	WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift
#	WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
@geriux geriux requested a review from chipsnyder December 29, 2020 10:21
@geriux geriux added this to the 16.5 milestone Dec 29, 2020
@geriux geriux marked this pull request as ready for review December 29, 2020 10:21
@geriux geriux modified the milestones: 16.5, 16.6 Dec 29, 2020
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on this cleanup @geriux! I had one concern RE: classic editor but the rest looks good to me :)

@geriux geriux requested a review from chipsnyder January 7, 2021 16:17
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @geriux :shipit:

@geriux geriux changed the base branch from develop to gutenberg/after_1.44.0 January 8, 2021 11:50
@geriux geriux changed the base branch from gutenberg/after_1.44.0 to develop January 8, 2021 12:18
@geriux geriux merged commit f59d751 into develop Jan 13, 2021
@geriux geriux deleted the gutenberg/remove-page-template-setting branch January 13, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants