Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Set empty chart bar height to chart height #11971

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

ScoutHarris
Copy link
Contributor

Ref #11876

For empty charts, the grey bars are now the height of the chart.

To test:


Latest Post Summary chart:

  • The empty view on this one is a bit hard to trigger.
    • A site with views, but no views in the past 2 weeks.
    • A site with no views, but has Likes or Comments.
  • Verify grey bars extend the height of the chart.

latest_post_summary


Period Overview chart:

  • On a site with no Views, Visitors, Likes, and/or Comments for all the periods on the chart.
  • Verify grey bars extend the height of the chart.

no_views_visitors

no_likes


Post Stats chart:

  • Access Post Stats for a site with no stats in the past 2 weeks.
  • Verify grey bars extend the height of the chart.

post_stats

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScoutHarris it looks perfect!
It worked as expected!
:shipit:

@ScoutHarris ScoutHarris merged commit b2b0181 into develop Jun 24, 2019
@ScoutHarris ScoutHarris deleted the feature/11876-empty_chart_bar_height branch June 24, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants