[Stats Refresh] Show grey bars when chart is empty #11887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comes in well after the other summary data.
…ere Likes was not updated after the query finished.
|
@danielebogo - I'm adding you as a reviewer in case you can get to this before @jklausa . Thanks! |
jklausa
reviewed
Jun 11, 2019
| let totalViews = summaryData.compactMap({$0.viewsCount}).reduce(0, +) | ||
| let totalVisitors = summaryData.compactMap({$0.visitorsCount}).reduce(0, +) | ||
| let totalLikes = summaryData.compactMap({$0.likesCount}).reduce(0, +) | ||
| let totalComments = summaryData.compactMap({$0.commentsCount}).reduce(0, +) |
jklausa
approved these changes
Jun 11, 2019
This was referenced Jun 11, 2019
|
Looks good @ScoutHarris Are we going to be able to update the bars to the gradient type at any point? if not can you add a version for consideration where the bars are the full height of the chart? |
|
Hey @SylvesterWilmott . Honestly I'm not sure. Adding the gradient turned out to be a bit complicated. If we do, it'll be a while. So I went ahead and extended the bar heights with #11971. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11876
Fixes #11888
This change displays light grey bars when a chart view is empty.
This also fixes an issue where chart Likes was not being updated after the Likes query finished.
To test:
Latest Post Summary chart:
Period Overview chart:
Post Stats chart:
Chart Likes:
Update release notes:
RELEASE-NOTES.txt.