-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stats Refresh] When charts have no data, show grey bars #11876
Comments
I'm not sure if it helps in any way but this is the code that build the empty data set on Android
The value of all the columns is 1F, the color goes from |
Thanks @planarvoid ! I'm sure this will come in handy. |
In the iOS version of the Charts, bar gradients have not been implemented. With #11887 , light grey bars were added to empty charts while we figure out if we can do gradients. There are two outstanding PRs attempting to do so in the library, but both are over a year old, and are build off of older version of the library: There are two (rather old) issues that may be useful if we decide to attempt this ourselves. |
With these changes, we're now showing grey bars: As stated previously, bar gradients were not implemented in the iOS Charts library. And doing so manually will take a bit of effort. I'm closing this as Done. If we really have to have gradient bars, we should discuss the effort vs benefit with another request. |
Currently, when the charts are empty, they show nothing. They should show short grey bars like Android does.
This applies to:
Examples:
iOS:
Android:
From @planarvoid in a Slack conversation - "I’m just showing gradient columns with max value of 1. grey to white."
The text was updated successfully, but these errors were encountered: