Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1 #2

Merged
merged 18 commits into from
Sep 17, 2020
Merged

Issue 1 #2

merged 18 commits into from
Sep 17, 2020

Conversation

websupporter
Copy link
Member

@websupporter websupporter commented Sep 11, 2020

This PR fixes #1

Currently done

  • W “Credit Cards” is selected we should focus on the first card field
  • Plugin author (“Plugin:” header) should be “WooCommerce”.
  • Downgrade to PHP 7.0
  • Remove the repositories section from composer.json
  • some violations of the WooCommerce standards
  • WooCommerce\ namespace
  • PHP notice logged when activating the plugin
  • DCC fields in Gateway description
  • Downgrade dhii/module-interface
  • Check if the PayPal account can process DCC before enabling the merchant to activate and set up the DCC gateway in WooCommerce

@websupporter websupporter changed the title [WIP] Issue 1 Issue 1 Sep 16, 2020
@jorgeatorres jorgeatorres self-assigned this Sep 17, 2020
@jorgeatorres jorgeatorres self-requested a review September 17, 2020 13:29
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @websupporter!

@Mr-Aspirapolvere Mr-Aspirapolvere mentioned this pull request Nov 14, 2023
@Lerie82 Lerie82 mentioned this pull request Feb 24, 2024
This was referenced Jun 7, 2024
inpsyde-maticluznar added a commit that referenced this pull request Nov 21, 2024
@lvvvvvl lvvvvvl mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing round 1 - feedback
2 participants