Update dhii\module-interface
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexP11223
reviewed
Jan 13, 2021
composer.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "description": "PayPal Commerce Platform for WooCommerce", | |||
| "license": "GPL-2.0", | |||
| "require": { | |||
| "dhii/module-interface": "0.1", | |||
| "dhii/module-interface": "0.2.x-dev", | |||
There was a problem hiding this comment.
Suggested change
| "dhii/module-interface": "0.2.x-dev", | |
| "dhii/module-interface": "^0.2", |
Maybe better to use this, that's what we do in other projects.
There was a problem hiding this comment.
@AlexP11223 done, thanks for the info 👍
|
0.2 requires PHP 7.1 (see https://github.com/Dhii/module-interface/blob/v0.2.0-alpha1/composer.json#L15), while #1 requires the plugin to be compatible with PHP7.0 |
|
@Dinamiko, this package has already been upgraded to use |
jorgeatorres
force-pushed
the
PCP-72-error-on-plugin-activation-with-i
branch
from
834e718 to
f5837f4
Compare
jorgeatorres
force-pushed
the
PCP-72-error-on-plugin-activation-with-i
branch
from
f5837f4 to
2a8ee97
Compare
jorgeatorres
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem when there is more than one instance of
dhii\module-interfacecomposer package by updating it to the latest version.